Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Jan 2004 15:13:38 -0800
From:      Sam Leffler <sam@errno.com>
To:        John Baldwin <jhb@freebsd.org>, Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 44709 for review
Message-ID:  <200401021513.38759.sam@errno.com>
In-Reply-To: <200401022204.i02M4ob5010556@repoman.freebsd.org>
References:  <200401022204.i02M4ob5010556@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 02 January 2004 02:04 pm, John Baldwin wrote:
> http://perforce.freebsd.org/chv.cgi?CH=44709
>
> Change 44709 by jhb@jhb_blue on 2004/01/02 14:04:27
>
> 	Bah, stupid bug.
>
> Affected files ...
>
> .. //depot/projects/smpng/sys/modules/crash/crash.c#8 edit
>
> Differences ...
>
> ==== //depot/projects/smpng/sys/modules/crash/crash.c#8 (text+ko) ====
>
> @@ -234,9 +234,9 @@
>  			break;
>  		case 18:
>  			bzero(&test1_mtx, sizeof(test1_mtx));
> -			bzero(&test1_mtx, sizeof(test2_mtx));
> +			bzero(&test2_mtx, sizeof(test2_mtx));
>  			mtx_init(&test1_mtx, "test1", NULL, MTX_DEF);
> -			mtx_init(&test1_mtx, "test2", NULL, MTX_DEF |
> +			mtx_init(&test2_mtx, "test2", NULL, MTX_DEF |
>  			    MTX_RECURSE);
>  #define TRYLOCK_TEST(lock, descr) do {					\
>  	status = mtx_trylock((lock));					\

Bah bah, bogus assertions.

	Sam



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401021513.38759.sam>