Date: Sat, 12 Jan 2019 12:40:31 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Warner Losh <imp@bsdimp.com> Cc: Enji Cooper <yaneurabeya@gmail.com>, Andrew Turner <andrew@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342963 - head/tests/sys/kern Message-ID: <201901122040.x0CKeVYC027664@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CANCZdfpZBbC%2BrPHm3sQWw8BAGzYdwctw7fAYst2UrfYbMbKZRg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > On Sat, Jan 12, 2019 at 12:10 PM Enji Cooper <yaneurabeya@gmail.com> wrote: > > > > > > > > On Jan 12, 2019, at 3:50 AM, Andrew Turner <andrew@FreeBSD.org> wrote: > > > > > > Author: andrew > > > Date: Sat Jan 12 11:50:39 2019 > > > New Revision: 342963 > > > URL: https://svnweb.freebsd.org/changeset/base/342963 > > > > > > Log: > > > Temporarily disable the kcov tests. Not all architectures have > > > atomic_store_64 and atomic_store_64. > > > > > > Sponsored by: DARPA, AFRL > > > > Hi Andrew, > > Would it make more sense to conditionally enable the tests on some > > architectures instead of disabling it on all architectures? > > > > No. Let's stop doing that. Either the architectures provide the 64-bit > stuff, or they will remain broken and removed. That makes a counter incentive for people to just break 32 bit archs with no reason to bother fixing them. This is a bad idea. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901122040.x0CKeVYC027664>