From owner-freebsd-acpi@FreeBSD.ORG  Wed Nov 17 22:48:40 2004
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7BB0E16A4D2
	for <acpi@FreeBSD.org>; Wed, 17 Nov 2004 22:48:40 +0000 (GMT)
Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 09EA843D54
	for <acpi@FreeBSD.org>; Wed, 17 Nov 2004 22:48:39 +0000 (GMT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 20274 invoked from network); 17 Nov 2004 22:48:38 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <scottl@FreeBSD.org>; 17 Nov 2004 22:48:38 -0000
Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iAHMmLfw093124;
	Wed, 17 Nov 2004 17:48:34 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: Nate Lawson <nate@root.org>
Date: Wed, 17 Nov 2004 17:44:53 -0500
User-Agent: KMail/1.6.2
References: <200411111737.00537.jhb@FreeBSD.org>
	<20041117205952.GB68320@ip.net.ua> <419BC030.5080803@root.org>
In-Reply-To: <419BC030.5080803@root.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200411171744.53665.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx
cc: acpi@FreeBSD.org
cc: scottl@FreeBSD.org
cc: freebsd-acpi@FreeBSD.org
cc: gallatin@FreeBSD.org
cc: Ruslan Ermilov <ru@FreeBSD.org>
Subject: Re: New ACPI PCI Link Routing code
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Nov 2004 22:48:40 -0000

On Wednesday 17 November 2004 04:18 pm, Nate Lawson wrote:
> Ruslan Ermilov wrote:
> > On Wed, Nov 17, 2004 at 11:24:48AM -0500, John Baldwin wrote:
> >>On Wednesday 17 November 2004 10:41 am, Ruslan Ermilov wrote:
> >>>I get a panic on boot with this change.  I don't have a serial
> >>>console attached to this notebook, but if needs be it can be
> >>>arranged (tomorrow).  The panic I get is as follows:
> >>>
> >>>panic: Assertion resource->Data.Irq.NumberOfInterrupts == 1 failed at
> >>>.../acpi_pci_link.c:497
> >>
> >>Can you print out what 'NumberOfInterrupts' is before the printf?  Drew
> >> has a machine that has hit the same panic as well.
> >
> > It's zero.
>
> Is line 497 in _CRS?  It's ok to return 0 interrupts from _CRS if the
> link was disabled.

Erm, unless I've got a logic bug I don't run the KASSERT() for zero 
interrupts.  Oh darn, I left a bogus KASSERT() in in the function that does 
the actual routing.  The assertion's on lines 497 and 511 can be dropped.  
I'll update the patch in a second.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org