From owner-freebsd-ports@FreeBSD.ORG  Thu Jul  2 16:35:21 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 808671065670;
	Thu,  2 Jul 2009 16:35:21 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe03.swip.net [212.247.154.65])
	by mx1.freebsd.org (Postfix) with ESMTP id A736E8FC1D;
	Thu,  2 Jul 2009 16:35:20 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=-C_3ZPTwNAkA:10
	a=MXw7gxVQKqGXY79tIT8aFQ==:17 a=MIZL5tirKvuxpDC4CEoA:9
	a=GyI1yVcXFpE8ZgnGlyIA:7 a=rR0p3Gm9NduG1zg1TqUaSaMPoPgA:4
Received: from [62.113.132.61] (account mc467741@c2i.net HELO
	laptop.adsl.tele2.no)
	by mailfe03.swip.net (CommuniGate Pro SMTP 5.2.13)
	with ESMTPA id 1276787630; Thu, 02 Jul 2009 18:35:19 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: Lawrence Stewart <lstewart@freebsd.org>
Date: Thu, 2 Jul 2009 18:34:50 +0200
User-Agent: KMail/1.11.4 (FreeBSD/8.0-CURRENT; KDE/4.2.4; i386; ; )
References: <200906080902.43391.hselasky@c2i.net> <4A4CCECA.40607@freebsd.org>
	<4A4CD909.7090400@freebsd.org>
In-Reply-To: <4A4CD909.7090400@freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907021834.53419.hselasky@c2i.net>
Cc: mezz7@cox.net, freebsd-ports@freebsd.org, markus@brueffer.de
Subject: Re: Temporary patch to fix USB in kdebase4
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2009 16:35:21 -0000

On Thursday 02 July 2009 17:58:01 Lawrence Stewart wrote:
> [trimmed CC list]
>
> Lawrence Stewart wrote:
> > Hans Petter Selasky wrote:
> >> On Thursday 02 July 2009 16:52:49 Lawrence Stewart wrote:
> >>> Hans Petter Selasky wrote:
> >>>> See attachment.
> >>>> --HPS
> >>>
> >>> Any chance you (or someone with the right clue) could update this patch
> >>> to work with more recent 8-CURRENT? I get the following output when
> >>> trying to compile kdebase4 (which applies your original patch as
> >>> extra-patch-libusb20) on r195046 world/kernel:
> >>>
> >>>
> >>> Scanning dependencies of target kcm_usb
> >>>
> >>> [ 67%] Building CXX object
> >>> apps/kinfocenter/usbview/CMakeFiles/kcm_usb.dir/kcm_usb_automoc.o
> >>> [ 67%] Building CXX object
> >>> apps/kinfocenter/usbview/CMakeFiles/kcm_usb.dir/kcmusb.o
> >>> In file included from
> >>> /usr/ports/x11/kdebase4/work/kdebase-4.2.4/apps/kinfocenter/usbview/usb
> >>>devi
> >>>
> >>> ces.h:20,
> >>
> >> Hi,
> >>
> >> It looks like you have two set of header files. Second, change the USB
> >> "dev/"  header files to:
> >>
> >> #  include <dev/usb/usb.h>
> >> #  include <dev/usb/usbdi.h>
> >>
> >> Else there are no further changes.
> >
> > ah ha, had forgotten to run "make delete-old" after last update. Thanks
> > for the hint and thanks for the include fix. Trying it out now.
>
> FYI, Hans your suggestion didn't work. Jeremy's on the other hand did.
> By only including <dev/usb/usb_ioctl.h> the compile finishes without issue.
>

Thinking about it you might be right. The files I mentioned are only used for 
kernel drivers, not userland. 

> I'm in the process of updating to today's current though and a lot of
> USB related changes were in the changeset so it's entirely possible
> running new kernel/world will make your comments valid.
>

Glad you found out what was wrong. 

--HPS