Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Nov 2014 11:10:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 193367] [panic] sleeping thread
Message-ID:  <bug-193367-8-7SLGiAUnek@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-193367-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-193367-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193367

--- Comment #13 from Eygene Ryabinkin <rea@FreeBSD.org> ---
Perhaps the more proper thing will be to say
.max_ioctl    = (DRM_ARRAY_SIZE(i915_ioctls) - 1)
since this will preserve the semantics of the "max_ioctl" name that should keep
the index of the last ioctl and not the number of driver-specific ioctls.

I'd go this route, though the change will be slightly more intrusive; namely
http://codelabs.ru/fbsd/patches/drm2/fix-drm_drv-off-by-one-v2.diff.

What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193367-8-7SLGiAUnek>