From owner-freebsd-standards@FreeBSD.ORG Wed Apr 10 14:10:01 2013 Return-Path: Delivered-To: freebsd-standards@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E9B22B21 for ; Wed, 10 Apr 2013 14:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id DAC23114 for ; Wed, 10 Apr 2013 14:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3AEA10t044881 for ; Wed, 10 Apr 2013 14:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3AEA1vH044880; Wed, 10 Apr 2013 14:10:01 GMT (envelope-from gnats) Date: Wed, 10 Apr 2013 14:10:01 GMT Message-Id: <201304101410.r3AEA1vH044880@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org Cc: From: Matthew Rezny Subject: Re: standards/177742: conflict of dd's bs= option with use of conv=sparse X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Matthew Rezny List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 14:10:02 -0000 The following reply was made to PR standards/177742; it has been noted by GNATS. From: Matthew Rezny To: bug-followup@FreeBSD.org Cc: Subject: Re: standards/177742: conflict of dd's bs= option with use of conv=sparse Date: Wed, 10 Apr 2013 15:31:08 +0200 The patch I suggested got a little messed up by the web form, and it also contained a typo. Further, I had neglected to consider the C_BS flag itself should be present after masking off the few allowed flags, so the patch should be amended as such follows. if (ddflags & C_BS) { out.dbcnt = in.dbcnt; - dd_out(1); + dd_out((ddflags & !(C_NOERROR | C_NOTRUNC | C_SYNC)) == C_BS); in.dbcnt = 0; continue; } This patch has been tested to confirm conv=sparse now works as expected with bs= set. No other conversions have been checked with the bs= option and from reading the code I don't think they will.