Date: Mon, 18 Sep 1995 23:07:03 -0700 From: David Greenman <davidg@Root.COM> To: Terry Lambert <terry@lambert.org> Cc: hackers@freefall.freebsd.org Subject: Re: why is this not a bug in namei? Message-ID: <199509190607.XAA03876@corbin.Root.COM> In-Reply-To: Your message of "Mon, 18 Sep 95 19:54:56 PDT." <199509190254.TAA09115@phaeton.artisoft.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>> >> Is this just a typo? Shouldn't it be a FREE() macro like below? >> ... >> >The code should still be cleaned up, however. >> > >> >I prefer the macroized version to allow later instrumentation. >> >> I prefer the non macroized version. The instrumentation of malloc/free >> belongs in malloc() & free(). Macros are ugly and usually evil. They >> unnecessarily obscure the code. > >??? > >What if I only want to instrument malloc() and free() in one source file? That's a silly argument. The namespace will already be messed up with the global macros - I'd hardly call that an "improvement". >What if I want to share code with NetBSD and BSDI? Then you've got far worse problems than a few macros. -DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199509190607.XAA03876>