Date: Thu, 2 Mar 2017 00:14:33 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Ngie Cooper <yaneurabeya@gmail.com> Cc: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.cn85.dnsmgr.net>, Alexey Dokuchaev <danfe@freebsd.org>, src-committers <src-committers@freebsd.org>, Ian Lepore <ian@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r314464 - head/usr.sbin/yppush Message-ID: <20170301231433.ux6j2rxmey6xmhct@ivaldir.etoilebsd.net> In-Reply-To: <CAGHfRMC6MHzHYJw0n2cu-npYP3LZfe=vxqOfAb9o76mEFwBQFw@mail.gmail.com> References: <20170301165916.kuizbr2w5l2beoac@ivaldir.etoilebsd.net> <201703011708.v21H89XW057584@pdx.rh.CN85.dnsmgr.net> <CAGHfRMC6MHzHYJw0n2cu-npYP3LZfe=vxqOfAb9o76mEFwBQFw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--4j4l23chfjqgui3u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Mar 01, 2017 at 02:41:23PM -0800, Ngie Cooper wrote:
> On Wed, Mar 1, 2017 at 9:08 AM, Rodney W. Grimes
> <freebsd-rwg@pdx.rh.cn85.dnsmgr.net> wrote:
> ...
> > At one point in history I can promise you that ALL symlinks in the rele=
ase
> > where shortest possible relative path. So any absolute links that ente=
red
> > the system got created by developers who where not aware that they shou=
ld
> > always use a relative link for anything landing in DESTDIR. This creat=
es
> > breakge on so many levels we should make a rapid correction to this
> > regression.
>=20
> This is why things are that way currently:
>=20
> $ git blame usr.bin/chpass/Makefile| grep ypchfn
> 780ae7713f72b (gjb 2016-01-28 01:15:57 +0000 29) SYMLINKS+=3D
> ${BINDIR}/chpass ${BINDIR}/ypchfn
> aca2488187113 (wosch 1997-09-13 12:21:25 +0000 35) MLINKS+=3D chpass.1
> ypchpass.1 chpass.1 ypchfn.1 chpass.1 ypchsh.1
> 5294f47313a2d (gjb 2016-01-28 02:56:30 +0000 39) .for i in chpass
> chfn chsh ypchpass ypchfn ypchsh
For thos in particular I think the right thing is actually to modify instal=
l so
if it creates hardlinks with chflags it should first check for chflags, rem=
ove
it make the hardlink and reapply. The issue would be that well you break wh=
at
chflags are for given you are workarounding it :)
Bapt
--4j4l23chfjqgui3u
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAli3VdAACgkQY4mL3PG3
PlriqBAA3IbSTeN4l0fB6FQqnMpf4McBKtmyHD0tA6CoXf+R+/d63t+KadLu/Ysh
X8u7GiVYgXk/FXZMeDDQ/dvck3PvqB+QnE8PuLhXDgtY7qZHlcdXVxVn41Jrc+zy
aKd0gW8jXxyIgwYOCODKKDwT7ClFid1X3JHZoOlrhSmglJwSXJ8oaYJGn4AmLEKd
J/d+isiuZXU3xMnbnUTBdWDZucF03APb5w+jFIcIxu/R73uWl0w6WV1G/dE+6YIj
pJ/N+VxDIJgqKoh8B/I7vuVSbbKfs0Yrx46O7MAeYYoNX5sM8R0PsTKT8Zx0URTf
46/wiHHiEiQesZSByM5f++JfKZJ0DGwlXNuqmWHsrAz2FX2g/V+9Z9kc3EXEgovS
6SGkEdUcMJpG+cTHup3nRxyPBL9qXo6VLlQOxZg4yqQp1hP56nAWYlB1BYLEPi5g
ysYKKTob0nma2ZGo2o6vbD7B9ihoumdhfbzdge1KLnWb7fB07wMW3uqeNDNF+z1V
giKEpyzK4+sspsBAb03rw+U9aXcB29+O197wJRn0AFFaStGub9bbAPW3/zsorzNJ
EUXF3O9GC8mRyv13ZSvjYeJR3zAr4avImUjCUgOgGJOUdNpUxjKzVgYxESmBBazC
osnYlHYWNUCHHwaQqgGpT3/5kcDdkKijHI7TBW2yTu9Ov8S4wZU=
=5vrW
-----END PGP SIGNATURE-----
--4j4l23chfjqgui3u--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170301231433.ux6j2rxmey6xmhct>