From owner-freebsd-apache@FreeBSD.ORG Wed Sep 4 15:55:24 2013 Return-Path: Delivered-To: apache@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D7AFFD28; Wed, 4 Sep 2013 15:55:24 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id F26942DA0; Wed, 4 Sep 2013 15:55:23 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA29302; Wed, 04 Sep 2013 18:55:15 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1VHFQJ-000709-Im; Wed, 04 Sep 2013 18:55:15 +0300 Message-ID: <522757BF.60300@FreeBSD.org> Date: Wed, 04 Sep 2013 18:54:39 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130810 Thunderbird/17.0.8 MIME-Version: 1.0 To: apache@FreeBSD.org, ohauer@FreeBSD.org Subject: www/apache22/files/patch-support__apachectl.in change in r322368 X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 15:55:24 -0000 http://svnweb.freebsd.org/ports?view=revision&revision=322368 Commit message says: - add fix for CVE-2013-1862 - adjust vuxml At the same time there is the following change to patch-support__apachectl.in: +-case $ARGV in +-start|stop|restart|graceful|graceful-stop) +- $HTTPD -k $ARGV ++case $ACMD in ++start|stop|restart|rcvar|reload|graceful|gracefulstop|graceful-stop) ++# $HTTPD -k $ARGV ++ $SERVICE $( echo $ACMD | tr -d '-' ) + ERROR=$? + ;; Of particular interest to me is this change from direct start of httpd to starting via service(8) command. There is no rationale for this change in commit message... Now I will describe a problem that this changes causes for us. Among other things we use piped loggers with apache. Our filter commands need custom PATH to be specified for them. Basically they start with: #!/usr/bin/env blah-blah And finding blah depends on the proper PATH. We are careful to set PATH before running apachectl. Everything used to work without any glitch. Now, service(8) does the following: exec env -i HOME=/ PATH=/sbin:/bin:/usr/sbin:/usr/bin $dir/$script $* This obviously nullifies any effects of our PATH customization. Our configuration became broken. Do you have any suggestions on how we can work around the problem? Another minor consequence of this change is that now apache22_enable="YES" must be set to start httpd even via apachectl. Previously it didn't have to be specified. And unlike rc.d/apache22 which accepts onestart/forcestart as all rc scripts do, apachectl rejects these commands. So, I think that the change: - was not appropriately committed but rather sneaked into another change - is a POLA violation - is a PITA So, perhaps you could consider reverting it? Thank you very much for all the hard work on apache ports. Hope that you will be able to help to resolve the reported issues. -- Andriy Gapon