From owner-svn-src-all@freebsd.org Thu Mar 7 20:43:59 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99B201524FB5; Thu, 7 Mar 2019 20:43:59 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ED65071F74; Thu, 7 Mar 2019 20:43:58 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x27Khtqb092244; Thu, 7 Mar 2019 12:43:55 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x27KhtYw092243; Thu, 7 Mar 2019 12:43:55 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201903072043.x27KhtYw092243@ gndrsh.dnsmgr.net> Subject: Re: svn commit: r344898 - stable/12/share/mk In-Reply-To: <201903072040.x27KeeDI055175@repo.freebsd.org> To: Konstantin Belousov Date: Thu, 7 Mar 2019 12:43:55 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: ED65071F74 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.977,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 20:43:59 -0000 > Author: kib > Date: Thu Mar 7 20:40:39 2019 > New Revision: 344898 > URL: https://svnweb.freebsd.org/changeset/base/344898 > > Log: > Disable WITH_RETPOLINE on stable/12. > > It is known that clang 7 generates broken ifunc calls when retpoline is > enabled. Since libc uses ifuncs, mark WITH_RETPOLINE as always broken > and disabled. To be removed after clang 8 MFC. > > This is a direct commit to the branch. > > Reported by: many > Tested by: Nikola Mihaylov > Reviewed by: emaste > Sponsored by: The FreeBSD Foundation Would an UPDATING entry be warranted? > Modified: > stable/12/share/mk/src.opts.mk > > Modified: stable/12/share/mk/src.opts.mk > ============================================================================== > --- stable/12/share/mk/src.opts.mk Thu Mar 7 20:12:50 2019 (r344897) > +++ stable/12/share/mk/src.opts.mk Thu Mar 7 20:40:39 2019 (r344898) > @@ -365,6 +365,9 @@ BROKEN_OPTIONS+=LOADER_UBOOT > BROKEN_OPTIONS+=LOADER_GELI LOADER_LUA > .endif > > +# clang 7.0 > +BROKEN_OPTIONS+=RETPOLINE > + > .if ${__T:Mmips64*} > # profiling won't work on MIPS64 because there is only assembly for o32 > BROKEN_OPTIONS+=PROFILE > > -- Rod Grimes rgrimes@freebsd.org