Date: Wed, 17 Sep 2003 23:39:15 -0500 From: Jeremy Messenger <mezz7@cox.net> To: Piero <piero@poprostu.pl> Cc: freebsd-gnome@freebsd.org Subject: Re: porting problem: linuxish paths in configure Message-ID: <oprvohvpif8ckrg5@smtp.central.cox.net> In-Reply-To: <20030918002534.35e8fd53.piero@poprostu.pl> References: <20030915072716.M96865@poprostu.pl> <20030918002534.35e8fd53.piero@poprostu.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
------------8B5Wh0eeW1Tg50f3BthVrM
Content-Type: text/plain; format=flowed; charset=utf-8
Content-Transfer-Encoding: 8bit
On Thu, 18 Sep 2003 00:25:34 +0200, Piero <piero@poprostu.pl> wrote:
> W liście otrzymanym Mon, 15 Sep 2003 08:27:15 +0100 od "Piero"
> <piero@poprostu.pl> :
>
>>
>> I am trying to port an application to FreeBSD. This is a devel GTK2
>> based version of polish/gnugadu instant messenger. This requires for
>> its default gadu-gadu (Polish IM network) functionality libgadu
>> library, that comes with the polish/ekg port.
>>
> [cut]
>
> Hi,
>
> This is a first public snapshot of the port I was doing.
> Can you have a look at this? I passed the Linux paths in
> configure - and I have learned some :-), but I noticed
> some other problems. I mention them as comments in the
> Makefile.
>
> I was taking other port skeletons as examples, but some
> solutions I saw and adopted, seem not to work in mine.
> I am talking about ${INSTALL_DATA} commands and Gnome
> Esound check that break my skeleton.
>
> I cannot see any error in them, did I miss something on
> the way? Thanks,
I haven't test it, but here's an attach of gnugadu2.diff..
Here are comments:
1) Remove 'GNU_CONFIGURE', because the USE_LIBTOOL is taking care of it.
Check in /usr/ports/Mk/bsd.port.mk for the more info of it.
2) Remove 'LIB_DEPENDS+=esd..', because the 'USE_GNOME+=esound' took care
of it.
3) I did add some comments in there..
Hope, it will run fine on the changes. :-) Also, you should install the
devel/portlint to check your port.
Cheers,
Mezz
> PS: The libtlen is a dependency that isn't in the ports yet
> - though I got it ready to commit - so please don't turn the
> knob on yet.
>
> PS2: Please, discard the pkg-message in Polish, this is
> for Polish peeple that I asked to test it.
>
> Thanks,
--
bsdforums.org 's moderator, mezz.
------------8B5Wh0eeW1Tg50f3BthVrM
Content-Disposition: attachment; filename=gnugadu2.diff
Content-Type: text/plain; name=gnugadu2.diff
Content-Transfer-Encoding: 8bit
diff -ur gnugadu2.orig/Makefile gnugadu2/Makefile
--- gnugadu2.orig/Makefile Wed Sep 17 23:30:47 2003
+++ gnugadu2/Makefile Wed Sep 17 23:36:11 2003
@@ -13,14 +13,13 @@
DISTNAME= gg2-${PORTVERSION:S/.p3/pre3/}
MAINTAINER= smyru@heron.pl
-COMMENT= "GTK2 based unstable version of GaduGadu client for X11/GTK"
+COMMENT= GTK2 based unstable version of GaduGadu client for X11/GTK
USE_X_PREFIX= yes
USE_GMAKE= yes
USE_GNOME= gtk20
USE_LIBTOOL= yes
USE_PERL5= yes
-GNU_CONFIGURE= yes
INSTALLS_SHLIB= yes
LIB_DEPENDS= gadu.2:${PORTSDIR}/polish/ekg
@@ -31,6 +30,8 @@
CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
LDFLAGS="-L${LOCALBASE}/lib"
+.include <bsd.port.pre.mk> # This is need or bottom won't work.
+
.if defined(WITH_DOCK)
CONFIGURE_ARGS+= --with-docklet
PLIST_SUB+= DOCK:=""
@@ -63,6 +64,9 @@
# this would break Makefile, why?
#
+# Add .include <bsd.port.pre.mk> above to fix it; it's in 33 line.
+# Also, you will have to put the .include <bsd.port.post.mk> in the bottom.
+#
#.if ${HAVE_GNOME:Mesound}!=""
#WITH_ESOUND= yes
#.endif
@@ -71,7 +75,6 @@
CONFIGURE_ARGS+= --with-esd
PKGNAMESUFFIX= -esound
USE_GNOME+= esound
-LIB_DEPENDS+= esd.2:${PORTSDIR}/audio/esound
PLIST_SUB+= ESOUND:=""
.else
CONFIGURE_ARGS+= --without-esd
@@ -105,6 +108,8 @@
# commented stuff breaks Makefile, why?
#
+# Same reason as with esound, check above for the comment.
+#
post-install:
.if exists(${X11BASE}/share/gnome/apps)
# @${INSTALL_DATA} ${WRKSRC}/gg2.desktop ${X11BASE}/share/gnome/apps/Internet
@@ -112,8 +117,8 @@
.else
PLIST_SUB+= GNOME:="@comment "
.endif
-.if exists(${LOCALBASE}/share/applnk/Internet)
-# @${INSTALL_DATA} ${WRKSRC}/gg2.desktop ${LOCALBASE}/share/applnk/Internet
+.if exists(${X11BASE}/share/applnk/Internet)
+# @${INSTALL_DATA} ${WRKSRC}/gg2.desktop ${X11BASE}/share/applnk/Internet
PLIST_SUB+= KDE:=""
.else
PLIST_SUB+= KDE:="@comment "
@@ -135,4 +140,4 @@
post-install:
@${CAT} ${PKGMESSAGE}
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
------------8B5Wh0eeW1Tg50f3BthVrM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?oprvohvpif8ckrg5>