From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Mar 13 12:50:03 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E332416A4CE for ; Sun, 13 Mar 2005 12:50:02 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 712EB43D48 for ; Sun, 13 Mar 2005 12:50:02 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j2DCo2JK005640 for ; Sun, 13 Mar 2005 12:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j2DCo2cN005639; Sun, 13 Mar 2005 12:50:02 GMT (envelope-from gnats) Resent-Date: Sun, 13 Mar 2005 12:50:02 GMT Resent-Message-Id: <200503131250.j2DCo2cN005639@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kang Liu Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AAEC16A4CE for ; Sun, 13 Mar 2005 12:46:32 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A86043D1D for ; Sun, 13 Mar 2005 12:46:32 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j2DCkTHj080596 for ; Sun, 13 Mar 2005 12:46:29 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id j2DCkT3R080595; Sun, 13 Mar 2005 12:46:29 GMT (envelope-from nobody) Message-Id: <200503131246.j2DCkT3R080595@www.freebsd.org> Date: Sun, 13 Mar 2005 12:46:29 GMT From: Kang Liu To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: ports/78779: [maintainer] Fix bad html filter in www/phpbb X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Mar 2005 12:50:03 -0000 >Number: 78779 >Category: ports >Synopsis: [maintainer] Fix bad html filter in www/phpbb >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Sun Mar 13 12:50:01 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Kang Liu >Release: 5.3 >Organization: Beijing University of Technology >Environment: FreeBSD 5.3-STABLE #0: Thu Jan 6 17:37:44 CST 2005 >Description: There is a low risk vulnerability in www/phpbb that allows users to bypass forum-wide configuration (VuXML ID 4a0b334d-8d8d-11d9-afa0-003048705d5a). The patch below can fix this problem. >How-To-Repeat: >Fix: --- /dev/null Sun Mar 13 20:38:18 2005 +++ files/patch-includes-usercp_register.php Sun Mar 13 20:29:28 2005 @@ -0,0 +1,23 @@ +--- includes/usercp_register.php.orig Sun Mar 13 19:44:02 2005 ++++ includes/usercp_register.php Sun Mar 13 19:48:34 2005 +@@ -145,10 +145,9 @@ + if ( $mode == 'register' ) + { + $attachsig = ( isset($HTTP_POST_VARS['attachsig']) ) ? ( ($HTTP_POST_VARS['attachsig']) ? TRUE : 0 ) : $board_config['allow_sig']; +- +- $allowhtml = ( isset($HTTP_POST_VARS['allowhtml']) ) ? ( ($HTTP_POST_VARS['allowhtml']) ? TRUE : 0 ) : $board_config['allow_html']; +- $allowbbcode = ( isset($HTTP_POST_VARS['allowbbcode']) ) ? ( ($HTTP_POST_VARS['allowbbcode']) ? TRUE : 0 ) : $board_config['allow_bbcode']; +- $allowsmilies = ( isset($HTTP_POST_VARS['allowsmilies']) ) ? ( ($HTTP_POST_VARS['allowsmilies']) ? TRUE : 0 ) : $board_config['allow_smilies']; ++ $allowhtml = ( ($board_config['allowhtml']) ) ? TRUE : 0; ++ $allowbbcode = ( ($board_config['allowbbcode']) ) ? TRUE : 0; ++ $allowsmilies = ( ($board_config['allowsmilies']) ) ? TRUE : 0; + } + else + { +@@ -1134,4 +1133,4 @@ + + include($phpbb_root_path . 'includes/page_tail.'.$phpEx); + +-?> +\ No newline at end of file ++?> --- Makefile.orig Sun Mar 13 20:29:07 2005 +++ Makefile Sun Mar 13 20:40:29 2005 @@ -7,6 +7,7 @@ PORTNAME= phpbb PORTVERSION= 2.0.13 +PORTREVISION= 1 CATEGORIES= www MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= ${PORTNAME} >Release-Note: >Audit-Trail: >Unformatted: