From owner-freebsd-ipfw Wed Jul 28 13:33: 9 1999 Delivered-To: freebsd-ipfw@freebsd.org Received: from cygnus.rush.net (cygnus.rush.net [209.45.245.133]) by hub.freebsd.org (Postfix) with ESMTP id 2E16714C3C; Wed, 28 Jul 1999 13:32:53 -0700 (PDT) (envelope-from bright@rush.net) Received: from localhost (bright@localhost) by cygnus.rush.net (8.9.3/8.9.3) with SMTP id QAA14034; Wed, 28 Jul 1999 16:32:59 -0400 (EDT) Date: Wed, 28 Jul 1999 16:32:58 -0400 (EDT) From: Alfred Perlstein Reply-To: Alfred Perlstein To: "Brian F. Feldman" Cc: Nate Williams , hackers@FreeBSD.ORG, freebsd-ipfw@FreeBSD.ORG Subject: Re: securelevel and ipfw zero In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ipfw@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 28 Jul 1999, Brian F. Feldman wrote: > On Wed, 28 Jul 1999, Nate Williams wrote: > > > > > > These were changes that were necessary to make ipfw readable enough that > > > I could work with it in this area. They aren't just to clean it up, or > > > just for change's sake. They need to stay in. > > > > C'mon now, re-ording the lines is *certainly* not necessary to work. > > That's true. I sure didn't do that. > > > > > *rant on* > > Brian, FreeBSD isn't your private playground for playing around, this is > > a group project, and you gotta follow the rules, or you don't get to > > play with the rest of the folks.... > > The rules don't say "leave the code that you work with in a bigger mess than > when you started." Cleaning up code is a fact of life, and it _NEEDS_ to be > done to get work done, very often. You have to learn to deal with that. > > > *rant off* and so it should remain, changes that provide readability to code should be committed, the only time documentation of code is wrong is when it it is incorrect. Increasing the size of the cvs repo is not a consideration when worthwhile docs can be incorperated, especially when the person who needs to maintain it requires changess for readability. Is there a point to hindering the maintainer's ongoing work? -Alfred Perlstein - [bright@rush.net|bright@wintelcom.net] systems administrator and programmer Wintelcom - http://www.wintelcom.net/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ipfw" in the body of the message