Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Jan 2016 18:25:38 +0000 (UTC)
From:      Ian Lepore <ian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r294671 - stable/10/sys/arm/arm
Message-ID:  <201601241825.u0OIPcx2061318@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ian
Date: Sun Jan 24 18:25:37 2016
New Revision: 294671
URL: https://svnweb.freebsd.org/changeset/base/294671

Log:
  MFC r289619:
  
    Follow the advice of the misplaced comment and don't access the map struct
    after freeing it.  Remove the comment whose uselessness has been revealed.

Modified:
  stable/10/sys/arm/arm/busdma_machdep.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/arm/arm/busdma_machdep.c
==============================================================================
--- stable/10/sys/arm/arm/busdma_machdep.c	Sun Jan 24 18:11:36 2016	(r294670)
+++ stable/10/sys/arm/arm/busdma_machdep.c	Sun Jan 24 18:25:37 2016	(r294671)
@@ -786,10 +786,9 @@ bus_dmamem_free(bus_dma_tag_t dmat, void
 		ba = coherent_allocator;
 	else
 		ba = standard_allocator;
-	uma_zfree(dmamap_zone, map);
 
 	free(map->slist, M_DEVBUF);
-	/* Be careful not to access map from here on. */
+	uma_zfree(dmamap_zone, map);
 
 	bufzone = busdma_bufalloc_findzone(ba, dmat->maxsize);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201601241825.u0OIPcx2061318>