Date: Thu, 19 Sep 2002 12:43:25 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Julian Elischer <julian@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c Message-ID: <984.1032432205@critter.freebsd.dk> In-Reply-To: Your message of "Thu, 19 Sep 2002 01:28:41 PDT." <200209190828.g8J8SfMv065815@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200209190828.g8J8SfMv065815@freefall.freebsd.org>, Julian Elischer writes: >julian 2002/09/19 01:28:41 PDT > > Modified files: > sys/kern uipc_mbuf.c > Log: > While well intentionned the check to see it there is a packet > header and return that length, was misguided. > > The check itself didn't take into account the fact that the > mbuf pointer pased in may be null, and the function is > defined specifically for cases where the caller knows what it wants. > Rather than fix the check I'm removing it as phk suggested. Not to mention that it failed to perform the other half of m_lenght()'s job: return a pointer to the last mbuf in the chain. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?984.1032432205>