From owner-freebsd-ports-bugs@freebsd.org Fri Jul 15 17:43:43 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77BF7B9AA43 for ; Fri, 15 Jul 2016 17:43:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 666C317B4 for ; Fri, 15 Jul 2016 17:43:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6FHhgin096673 for ; Fri, 15 Jul 2016 17:43:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Update to 2.0.4.1; add devel/godot-tools port Date: Fri, 15 Jul 2016 17:43:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 17:43:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 --- Comment #51 from lightside --- (In reply to comment #49) > With the upcoming release of 11.0 we also need to add a small adjustment = to RtAudio.cpp. > > This updated patch adds the following to the previous 2.0.4.1 update to t= he > end of files/patch-drivers_rtaudio_RtAudio.cpp. sampleRate is an unsigned= int > so srate gets promoted to unsigned int, this means the result is always > positive so the use of abs() is of no use. I think, that your logic about srate is wrong, because srate defined as int: https://github.com/godotengine/godot/blob/820dd1d0016763cda6177104e66e09c86= 34150be/drivers/rtaudio/RtAudio.cpp#L9018 I placed following debug code near your patched place: printf("srate=3D%d, sampleRate=3D%d, srate - sampleRate =3D %d, abs(srate - sampleRate) =3D %d\n", srate, sampleRate, srate - sampleRate, abs(srate - sampleRate)); with following output: srate=3D44100, sampleRate=3D44100, srate - sampleRate =3D 0, abs(srate - sa= mpleRate) =3D 0 But there are other possible cases, where abs is needed. -8<-- #include #include int check(int a, unsigned int b) { return (a - b) > 100; } int check_abs(int a, unsigned int b) { return abs(a - b) > 100; } int main() { unsigned int c =3D 44200; for (int i =3D 44100; i <=3D 44300; i +=3D 100) printf("check(%d, %d) =3D %d; check_abs(%d, %d) =3D %d\n", = i, c, check(i, c), i, c, check_abs(i, c)); return 0; } -->8- % c++ test.cpp -o test && ./test check(44100, 44200) =3D 1; check_abs(44100, 44200) =3D 0 check(44200, 44200) =3D 0; check_abs(44200, 44200) =3D 0 check(44300, 44200) =3D 0; check_abs(44300, 44200) =3D 0 Without abs, the first case is wrong, i.e. possible srate =3D 44100 and sampleRate =3D 44200. There are cases with fabs in the same code: https://github.com/godotengine/godot/blob/820dd1d0016763cda6177104e66e09c86= 34150be/drivers/rtaudio/RtAudio.cpp#L1093 https://github.com/godotengine/godot/blob/820dd1d0016763cda6177104e66e09c86= 34150be/drivers/rtaudio/RtAudio.cpp#L1148 And this is not related to FreeBSD 11 at all, because issue with abs is different, related to possible abs redefinition. There are many other place= s in the source code with abs usage: https://github.com/godotengine/godot/blob/820dd1d0016763cda6177104e66e09c86= 34150be/drivers/opus/celt/celt_encoder.c#L651 https://github.com/godotengine/godot/blob/820dd1d0016763cda6177104e66e09c86= 34150be/drivers/opus/celt/cwrs.c#L447 https://github.com/godotengine/godot/blob/820dd1d0016763cda6177104e66e09c86= 34150be/drivers/theora/analyze.c#L753 https://github.com/godotengine/godot/blob/820dd1d0016763cda6177104e66e09c86= 34150be/drivers/vorbis/floor1.c#L265 etc. --=20 You are receiving this mail because: You are the assignee for the bug.=