Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 08 Apr 2006 16:16:30 -0700
From:      Nate Lawson <nate@root.org>
To:        Paul Saab <ps@FreeBSD.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/amr amr.c amr_pci.c amrvar.h
Message-ID:  <4438444E.7040009@root.org>
In-Reply-To: <20060408022346.A583C16A4E4@hub.freebsd.org>
References:  <20060408022346.A583C16A4E4@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Paul Saab wrote:
> ps          2006-04-08 02:23:27 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/amr          amr.c amr_pci.c amrvar.h 
>   Log:
>   Close a pesky race where after checking the BUSY flag in amr_wait_command,
>   the completion of the command can occur before tsleep is called and
>   the command ends up blocking forever since the wakeup has already
>   been called.
>   
>   Submitted by:   ups
>   
>   Revision  Changes    Path
>   1.76      +19 -6     src/sys/dev/amr/amr.c
>   1.35      +1 -0      src/sys/dev/amr/amr_pci.c
>   1.31      +1 -0      src/sys/dev/amr/amrvar.h

This would be a good audit task to do on the whole kernel.  There are 
very few legitimate uses of tsleep() these days.

-- 
Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4438444E.7040009>