From owner-cvs-all@FreeBSD.ORG Sat Apr 8 23:17:19 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6AE8A16A401; Sat, 8 Apr 2006 23:17:19 +0000 (UTC) (envelope-from nate@root.org) Received: from mail.aloha.net (mail.aloha.net [64.75.176.98]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76C3043D6E; Sat, 8 Apr 2006 23:17:15 +0000 (GMT) (envelope-from nate@root.org) Received: from localhost (localhost [127.0.0.1]) by mail.aloha.net (Postfix) with ESMTP id 2A475F1A3D; Sat, 8 Apr 2006 13:17:14 -1000 (HST) X-Virus-Scanned: by amavisd-new at aloha.net Received: from mail.aloha.net ([127.0.0.1]) by localhost (lacewood.aloha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5AGSOd7yrUIc; Sat, 8 Apr 2006 13:17:12 -1000 (HST) Received: from [10.0.0.150] (ip64-75-163-14.hsia.aloha.net [64.75.163.14]) by mail.aloha.net (Postfix) with ESMTP id 9C2E9F1A3C; Sat, 8 Apr 2006 13:17:12 -1000 (HST) Message-ID: <4438444E.7040009@root.org> Date: Sat, 08 Apr 2006 16:16:30 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Paul Saab References: <20060408022346.A583C16A4E4@hub.freebsd.org> In-Reply-To: <20060408022346.A583C16A4E4@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/amr amr.c amr_pci.c amrvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Apr 2006 23:17:19 -0000 Paul Saab wrote: > ps 2006-04-08 02:23:27 UTC > > FreeBSD src repository > > Modified files: > sys/dev/amr amr.c amr_pci.c amrvar.h > Log: > Close a pesky race where after checking the BUSY flag in amr_wait_command, > the completion of the command can occur before tsleep is called and > the command ends up blocking forever since the wakeup has already > been called. > > Submitted by: ups > > Revision Changes Path > 1.76 +19 -6 src/sys/dev/amr/amr.c > 1.35 +1 -0 src/sys/dev/amr/amr_pci.c > 1.31 +1 -0 src/sys/dev/amr/amrvar.h This would be a good audit task to do on the whole kernel. There are very few legitimate uses of tsleep() these days. -- Nate