Date: Thu, 8 Jun 2017 22:52:55 -0400 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Adam Weinberger <adamw@adamw.org> Cc: "Sergey A. Osokin" <osa@FreeBSD.org>, Bartek Rutkowski <robak@FreeBSD.org>, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r442588 - in head/www: nginx nginx-full Message-ID: <0130a05b-8f04-1008-16bf-d7f047823cae@FreeBSD.org> In-Reply-To: <20170606093911.GA98412@FreeBSD.org> References: <201706042038.v54KcQMf001482@repo.freebsd.org> <20170605001807.GA55217@FreeBSD.org> <C38A2113-0736-4687-91D8-D49722D61E35@adamw.org> <20170606093911.GA98412@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gAQC5hpUQPlbDn4trngmRDqJgpP7f80pN Content-Type: multipart/mixed; boundary="BjCvGCLdVwMxHGlLcnrtFCmdTiUnfGp3h"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Adam Weinberger <adamw@adamw.org> Cc: "Sergey A. Osokin" <osa@FreeBSD.org>, Bartek Rutkowski <robak@FreeBSD.org>, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <0130a05b-8f04-1008-16bf-d7f047823cae@FreeBSD.org> Subject: Re: svn commit: r442588 - in head/www: nginx nginx-full References: <201706042038.v54KcQMf001482@repo.freebsd.org> <20170605001807.GA55217@FreeBSD.org> <C38A2113-0736-4687-91D8-D49722D61E35@adamw.org> <20170606093911.GA98412@FreeBSD.org> In-Reply-To: <20170606093911.GA98412@FreeBSD.org> --BjCvGCLdVwMxHGlLcnrtFCmdTiUnfGp3h Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/6/17 5:39 AM, Alexey Dokuchaev wrote: > On Mon, Jun 05, 2017 at 05:50:06PM -0600, Adam Weinberger wrote: >>> On 4 Jun, 2017, at 18:18, Sergey A. Osokin <osa@FreeBSD.org> wrote: >>> >>> Hi Bartek and Adam, >>> >>> I don't think I can get this, so two questions for you guys: >>> o) what was the reason to bump PORTREVISION in www/nginx? >>> o) wouldn't it btter to just bump PORTREVISION in www/nginx-full? >> >> Hi Sergey, >=20 > [ Wrapping very long lines ] >=20 >> I'll give Bartek a chance to explain in more detail, but I supported a= n >> nginx bump because it was less complex for the future. >> >> If nginx-full got a bump, then it would need to be bumped every time >> nginx got bumped, or nginx would have to be bumped by two and nginx-fu= ll's >> PORTREVISION line gets removed, and then the line has to be removed at= the >> next nginx update or reset. At the end of the day, bumping nginx was m= ore >> straightforward. It triggers an update for everyone else, but becomes = less >> invasive over the long haul. >=20 > It seems that everyone bumps port revisions whenever they please these = days; > wondering about it just a waste of time. Just an exampler: r442562, wh= ere > it was bumped for pkg-descr change (sic!) in a port that takes consider= able > time to build. :-( >=20 pkg-descr is part of the generated package. Bumping PORTREVISION in that commit had a real impact and change. Plus the actual content change is not a small spelling change. > # svn diff -c r442561 ^/ > Index: head/emulators/wine/pkg-descr > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- head/emulators/wine/pkg-descr (revision 442560) > +++ head/emulators/wine/pkg-descr (revision 442561) > @@ -5,8 +5,12 @@ without the performance or memory usage penalties > a similar look and feel to other applications on your desktop. >=20 > Many applications already work, more or less, including versions of > -Microsoft Office and several games. > +Microsoft Office and many games. >=20 > +Use this port for 32-bit Windows binaries in an i386 environment or > +64-bit Windows binaries in an amd64 environment; use emulators/i386-wi= ne > +for 32-bit Windows binaries in an amd64 environment. > + It's explaining something to users about the proper use of the port and how to obtain the right package for the right environment. Yes it hurts to rebuild a port for something like this, but it is absolutely correct. Building ports synchronously in your terminal while waiting for them is the root problem here; building ports asynchronously in the background with a package builder and not caring when they are done is the right solution. It would be nice if the tools and metadata were smart enough to just reuse the existing package and update the pkg-descr within it. Until that time a rebuild is needed. > WWW: http://www.winehq.org/ >=20 > Gerald Pfeifer <gerald@FreeBSD.org> --=20 Regards, Bryan Drewery --BjCvGCLdVwMxHGlLcnrtFCmdTiUnfGp3h-- --gAQC5hpUQPlbDn4trngmRDqJgpP7f80pN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJZOg2HAAoJEDXXcbtuRpfPOvMH/1nKbarE/kHAyDkJ1GJoM/J6 QzsZDTItIvsIlPcrDe+HWGaeRQE/s6PMYIF1qsmgdQGcmPpCq0Kw5FaSwXxyOhaX 63+45iC5vWrz9dM8XWRi4lBuMV+n+zI3gHpK2fUjCFiA1ZF3yVPVU1MxlTz1D8Kv oGCMJ1zOlS5jbQj8eCcI45vZQprecft50BumXt4LX9/JZGLB9Hx6f7GAFSKYfAVy gHcmgMzLmX7ud0+IO9hkpiXaHqjV8S0IVdjmAosWtV6I0R5spayy15uzE6Voe47Z RwU4K/KaErvV+QBxZlx2pijz9z5R8d1zyO3VZl/8Xh3+hQGFgRpaZVRYRRHsunI= =Euh1 -----END PGP SIGNATURE----- --gAQC5hpUQPlbDn4trngmRDqJgpP7f80pN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0130a05b-8f04-1008-16bf-d7f047823cae>