Date: Mon, 9 Jul 2012 15:21:30 GMT From: Hiroshi Nishida <nishida@asusa.net> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/169736: Patch for broken net-im/libjingle port Message-ID: <201207091521.q69FLUTh001596@red.freebsd.org> Resent-Message-ID: <201207091530.q69FU9VL014668@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169736
>Category: ports
>Synopsis: Patch for broken net-im/libjingle port
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Jul 09 15:30:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Hiroshi Nishida
>Release: 8.3-RELEASE-p1 amd64
>Organization:
ASUSA Corporation
>Environment:
FreeBSD rd03.asusa-internal.net 8.3-RELEASE-p1 FreeBSD 8.3-RELEASE-p1 #0: Wed May 16 09:53:31 PDT 2012 nishida@rd03.asusa-internal.net:/usr/obj/usr/src/sys/MYKERNEL amd64
>Description:
net-im/libjingle is marked as BROKEN for non i386 systems.
This is due to a mismatch in types "size_t != unsigned int" on non i386 systems.
I have attached a patch for fixing it.
>How-To-Repeat:
Just compile and see an error.
>Fix:
Put the attached patch in "net-im/libjingle/files/" and make.
Patch attached with submission follows:
--- talk/session/fileshare/fileshare.cc.orig 2012-07-05 15:29:12.000000000 -0700
+++ talk/session/fileshare/fileshare.cc 2012-07-05 15:45:43.000000000 -0700
@@ -670,8 +670,8 @@
&& !query.empty()
&& (sscanf(query.c_str(), "width=%u&height=%u",
&width, &height) == 2)) {
- width = talk_base::_max<unsigned int>(1, talk_base::_min(width, kMaxPreviewSize));
- height = talk_base::_max<unsigned int>(1, talk_base::_min(height, kMaxPreviewSize));
+ width = talk_base::_max<unsigned int>(1, talk_base::_min((size_t)width, kMaxPreviewSize));
+ height = talk_base::_max<unsigned int>(1, talk_base::_min((size_t)height, kMaxPreviewSize));
std::string pathname;
if (is_sender_) {
talk_base::Pathname local_path;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201207091521.q69FLUTh001596>