From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jul 9 15:30:10 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C6341065670 for ; Mon, 9 Jul 2012 15:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1B7688FC17 for ; Mon, 9 Jul 2012 15:30:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q69FU9H1014669 for ; Mon, 9 Jul 2012 15:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q69FU9VL014668; Mon, 9 Jul 2012 15:30:09 GMT (envelope-from gnats) Resent-Date: Mon, 9 Jul 2012 15:30:09 GMT Resent-Message-Id: <201207091530.q69FU9VL014668@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Hiroshi Nishida Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7633A106566B for ; Mon, 9 Jul 2012 15:21:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 61CCD8FC0A for ; Mon, 9 Jul 2012 15:21:30 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q69FLUDT001597 for ; Mon, 9 Jul 2012 15:21:30 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q69FLUTh001596; Mon, 9 Jul 2012 15:21:30 GMT (envelope-from nobody) Message-Id: <201207091521.q69FLUTh001596@red.freebsd.org> Date: Mon, 9 Jul 2012 15:21:30 GMT From: Hiroshi Nishida To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/169736: Patch for broken net-im/libjingle port X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 15:30:10 -0000 >Number: 169736 >Category: ports >Synopsis: Patch for broken net-im/libjingle port >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jul 09 15:30:09 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Hiroshi Nishida >Release: 8.3-RELEASE-p1 amd64 >Organization: ASUSA Corporation >Environment: FreeBSD rd03.asusa-internal.net 8.3-RELEASE-p1 FreeBSD 8.3-RELEASE-p1 #0: Wed May 16 09:53:31 PDT 2012 nishida@rd03.asusa-internal.net:/usr/obj/usr/src/sys/MYKERNEL amd64 >Description: net-im/libjingle is marked as BROKEN for non i386 systems. This is due to a mismatch in types "size_t != unsigned int" on non i386 systems. I have attached a patch for fixing it. >How-To-Repeat: Just compile and see an error. >Fix: Put the attached patch in "net-im/libjingle/files/" and make. Patch attached with submission follows: --- talk/session/fileshare/fileshare.cc.orig 2012-07-05 15:29:12.000000000 -0700 +++ talk/session/fileshare/fileshare.cc 2012-07-05 15:45:43.000000000 -0700 @@ -670,8 +670,8 @@ && !query.empty() && (sscanf(query.c_str(), "width=%u&height=%u", &width, &height) == 2)) { - width = talk_base::_max(1, talk_base::_min(width, kMaxPreviewSize)); - height = talk_base::_max(1, talk_base::_min(height, kMaxPreviewSize)); + width = talk_base::_max(1, talk_base::_min((size_t)width, kMaxPreviewSize)); + height = talk_base::_max(1, talk_base::_min((size_t)height, kMaxPreviewSize)); std::string pathname; if (is_sender_) { talk_base::Pathname local_path; >Release-Note: >Audit-Trail: >Unformatted: