From owner-svn-ports-all@FreeBSD.ORG Wed Apr 24 19:08:02 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 4371EC02; Wed, 24 Apr 2013 19:08:02 +0000 (UTC) (envelope-from olgeni@FreeBSD.org) Received: from olgeni.olgeni.com (olgeni.olgeni.com [31.171.246.156]) by mx1.freebsd.org (Postfix) with ESMTP id 09C3D1790; Wed, 24 Apr 2013 19:08:01 +0000 (UTC) Received: from olgeni.olgeni (dynamic-adsl-94-36-172-31.clienti.tiscali.it [94.36.172.31]) by olgeni.olgeni.com (Postfix) with ESMTPSA id B6DCA17448B; Wed, 24 Apr 2013 21:08:00 +0200 (CEST) Date: Wed, 24 Apr 2013 21:08:00 +0200 (CEST) From: Jimmy Olgeni X-X-Sender: olgeni@olgeni.olgeni To: Jung-uk Kim Subject: Re: svn commit: r316469 - head/databases/slony1v2 In-Reply-To: <51782B87.2090000@FreeBSD.org> Message-ID: References: <201304241850.r3OIovPc079999@svn.freebsd.org> <51782B87.2090000@FreeBSD.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 19:08:02 -0000 On Wed, 24 Apr 2013, Jung-uk Kim wrote: > On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote: >> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New Revision: 316469 >> URL: http://svnweb.freebsd.org/changeset/ports/316469 >> >> Log: - Use bsd.port.options.mk. - PORTDOCS should not be >> conditional. - Whitespace fix. > ... > > bsd.port.mk says "(PORTDOCS) should not be set when no documentation > files are installed" and I believe it is actually correct. I found this on the Porter's Handbook: If a directory is listed in PORTDOCS or matched by a glob pattern from this variable, the entire subtree of contained files and directories will be registered in the final packing list. If the DOCS option has been unset then files and directories listed in PORTDOCS would not be installed or added to port packing list. It seems to behave correctly, at least in the PORTDOCS=* case. -- jimmy