From owner-freebsd-hackers Wed Sep 25 8:51:17 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0DD9037B401 for ; Wed, 25 Sep 2002 08:51:16 -0700 (PDT) Received: from mail.thundernet.cz (mail.thundernet.cz [62.77.87.114]) by mx1.FreeBSD.org (Postfix) with SMTP id 740FB43E75 for ; Wed, 25 Sep 2002 08:51:14 -0700 (PDT) (envelope-from neuhauser@bellavista.cz) Received: (qmail 4913 invoked from network); 25 Sep 2002 15:51:07 -0000 Received: from unknown (HELO freepuppy.bellavista.cz) (62.168.44.50) by mail.thundernet.cz with SMTP; 25 Sep 2002 15:51:07 -0000 Received: by freepuppy.bellavista.cz (Postfix, from userid 1001) id 5C54C2FDAB2; Wed, 25 Sep 2002 17:51:04 +0200 (CEST) Date: Wed, 25 Sep 2002 17:51:04 +0200 From: Roman Neuhauser To: Bruce M Simpson , freebsd-hackers@freebsd.org Subject: Re: periodic(8)-produced diffs Message-ID: <20020925155104.GR30361@freepuppy.bellavista.cz> Mail-Followup-To: Bruce M Simpson , freebsd-hackers@freebsd.org References: <20020923150536.GB30361@freepuppy.bellavista.cz> <20020923151059.GJ23343@spc.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020923151059.GJ23343@spc.org> User-Agent: Mutt/1.5.1i Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG # bms@spc.org / 2002-09-23 16:10:59 +0100: > On Mon, Sep 23, 2002 at 05:05:36PM +0200, Roman Neuhauser wrote: > [... re periodic diffs] > > And, what would the preferred interface be? Most of periodic.conf > > knobs are bools, but I'm not sure > > diff_{context,traditional,unified}_format="{YES,NO}" > > is better than > > diff_format="{context,traditional,unified}" > > No reason why rc.conf knobs *have* to be bools, what ultimately > matters is the case...esac which parses them. I'd avoid relying on a > default value in /etc/defaults/rc.conf for the sake of robustness. > > I prefer unified diffs, personally. thanks for your input. another thing I'm not sure about: should this knob be limited to just setting the diff format? there's also the possibility of going the rc.conf ${program}_flags path. i guess the question is whether the interface should be limited to a safe set of settings, or if the users should be able to shoot themselves in the foot in any way they want. quite a few diff switches don't make any sense in the actions performed by the periodic scripts, but IMO it's root's duty to choose a reasonable set. i think i'll try the $diff_program_options route, and post the patch later today or tomorrow. -- begin 666 nonexistent.vbs FreeBSD 4.7-RC 5:43PM up 8 days, 58 mins, 18 users, load averages: 0.06, 0.12, 0.07 end To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message