Date: Tue, 3 Jul 2007 12:14:33 -0400 From: John Baldwin <jhb@freebsd.org> To: Konstantin Belousov <kib@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sysv_sem.c Message-ID: <200707031214.34272.jhb@freebsd.org> In-Reply-To: <200707031558.l63FwmJx077238@repoman.freebsd.org> References: <200707031558.l63FwmJx077238@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 03 July 2007 11:58:48 am Konstantin Belousov wrote: > kib 2007-07-03 15:58:48 UTC > > FreeBSD src repository > > Modified files: > sys/kern sysv_sem.c > Log: > Relock the sema_mtxp unconditionally after copyin() for SETALL case in > kern_semctl. Otherwise, later mtx_unlock() can operate on unlocked mutex. > > Submitted by: rdivacky > MFC after: 3 days > Approved by: re (kensmith) Good catch. Another thing you could fix is to make all the 'goto done2' inside the switch cases just use 'break' instead. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707031214.34272.jhb>