Date: Thu, 9 Aug 2012 07:30:43 +0200 From: Hans Petter Selasky <hselasky@c2i.net> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Ed Schouten <ed@80386.nl>, freebsd-current@freebsd.org Subject: Re: ttydev_cdevsw has no d_purge Message-ID: <201208090730.43919.hselasky@c2i.net> In-Reply-To: <20120808215155.GP2676@deviant.kiev.zoral.com.ua> References: <20120801160323.GN2676@deviant.kiev.zoral.com.ua> <201208081942.24619.hselasky@c2i.net> <20120808215155.GP2676@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 08 August 2012 23:51:55 Konstantin Belousov wrote: > On Wed, Aug 08, 2012 at 07:42:24PM +0200, Hans Petter Selasky wrote: > > On Wednesday 08 August 2012 19:24:18 Ed Schouten wrote: > > > 2012/8/8 Hans Petter Selasky <hselasky@c2i.net>: > > > >> I have a question regarding the changed fragment of code. Why don't > > > >> you use unr(9) KPI to manage unit numbers ? > > > > > > > > Probably I could, but right now the unr interface doesn't support > > > > pending unit free which I need for other reasons, see below. > > > > > > What does `pending unit free' mean? I also would prefer it if you used > > > unr(9) -- not just here, but across the entire USB stack. > > > > It is like a drain state, where a unit is collected for free, and then > > committed to free state when the tsw_free() is called. In the [unlocked] > > time in between the unit cannot be re-used. > > Still, why do you need such intermediate state ? You cannot reuse the unit > number while it is in the 'pending free' still, AFAIU. Because of the order in which structures are freed. See other e-mail. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208090730.43919.hselasky>