From owner-cvs-all@FreeBSD.ORG Fri Mar 16 17:42:08 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4EEC416A405 for ; Fri, 16 Mar 2007 17:42:08 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.227]) by mx1.freebsd.org (Postfix) with ESMTP id D947513C448 for ; Fri, 16 Mar 2007 17:42:07 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wx-out-0506.google.com with SMTP id s18so601809wxc for ; Fri, 16 Mar 2007 10:42:07 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=WTHkk6YH9nDqur6eEe0Wm5TKBmJqwbkd6Bge/Ca8WnrB8vqkxTaj2oFuzLZBYlGQChCI7mVBNrEX+ArQWa5E2vDT37+St4V4LL2qpzOY7vHQKSYUyjJAYlkK5eOmwefOFU4f3OIXZdqJU9k9Vx0QV+aU7Z9Xx2mfSwNyrWX5t00= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=AtJTS4yiFJ1mDevesXknOPd697yHHl4faSGFMxXDBi1up3+u4njvkpUT60kuiX4/xmjiYcEc7Tht0lEMoHXLZ00rW7jAb4864+UH6pKA1AbqHHyHvx9PF/MgRTdXWbjfBjwFxnBDyRlS2Sh7up1txZGB5YEwhth2/KJKviKM7wI= Received: by 10.90.52.2 with SMTP id z2mr2109692agz.1174066926653; Fri, 16 Mar 2007 10:42:06 -0700 (PDT) Received: by 10.90.25.1 with HTTP; Fri, 16 Mar 2007 10:42:06 -0700 (PDT) Message-ID: Date: Fri, 16 Mar 2007 10:42:06 -0700 From: "Kip Macy" To: "Kip Macy" , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org In-Reply-To: <20070316101712.GA1243@straylight.m.ringlet.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070316101712.GA1243@straylight.m.ringlet.net> Cc: Subject: Re: cvs commit: src/share/man/man4 Makefile src/sys/dev/cxgb cxgb_adapter.h cxgb_config.h cxgb_ioctl.h cxgb_lro.c cxgb_main.c cxgb_osdep.h cxgb_sge.c t3fw-3.2.bin.gz.uu src/sys/dev/cxgb/common cxgb_ael1002.c cxgb_common.h cxgb_firmware_exports.h cxgb X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2007 17:42:08 -0000 Well - you answered my question "What gcc option(s) trigger this problem?" - the defaults don't. I don't like fixing problems I can't verify. I'll probably check in your change tonight. -Kip On 3/16/07, Peter Pentchev wrote: > On Thu, Mar 15, 2007 at 10:35:49PM -0700, Kip Macy wrote: > > > > > > On 3/15/07, Peter Pentchev wrote: > > >On Thu, 15 Mar 2007 at 03:06:32 +0000 (UTC), Kip Macy wrote: > > >> > > >> kmacy 2007-03-15 03:06:32 UTC > > >> > > >> FreeBSD src repository > > >> > > >> Modified files: (Branch: RELENG_6) > > >> share/man/man4 Makefile > > >> Added files: (Branch: RELENG_6) > > >> sys/dev/cxgb cxgb_adapter.h cxgb_config.h cxgb_ioctl.h > > >> cxgb_lro.c cxgb_main.c cxgb_osdep.h > > >> cxgb_sge.c t3fw-3.2.bin.gz.uu > > >> sys/dev/cxgb/common cxgb_ael1002.c cxgb_common.h > > >> cxgb_firmware_exports.h cxgb_mc5.c > > >> cxgb_mv88e1xxx.c cxgb_regs.h > > >> cxgb_sge_defs.h cxgb_t3_cpl.h > > >> cxgb_t3_hw.c cxgb_tcb.h cxgb_version.h > > >> cxgb_vsc8211.c cxgb_xgmac.c > > >> sys/modules/cxgb Makefile > > >> Log: > > >> MFC Chelsio T3 10 Gigabit Ethernet support > > >> > > >> Don't hook into build just > > > > > >Is it possible that the GCC version in 6.x-STABLE is different from > > >that in -CURRENT? On my laptop (i386, yesterday's -STABLE) LINT failed > > >to build with the following: > > > > > >/fs/6/usr.src/sys/dev/cxgb/cxgb_sge.c: In function `sge_timer_reclaim': > > >/fs/6/usr.src/sys/dev/cxgb/cxgb_sge.c:172: warning: inlining failed in > > >call to 'refill_rspq': function body not available > > >/fs/6/usr.src/sys/dev/cxgb/cxgb_sge.c:699: warning: called from here > > > > > >It seems it simply needed refill_rspq() to be moved up, so that > > >the compiler could actually see the function body before first use; > > >or is this a bug in GCC? > > > > > >Anyway, here's a simple patch that fixed the LINT build for me. > > > > I'm not saying it isn't a problem - but I can't reproduce it on my > > system. I see all sorts of inlining complaints from other modules but > > not cxgb. Are you sure you don't have a modified make.conf? > > Actually, yes, I was using a slightly modified make.conf. After playing > around for a while it turned out that the "problem" was a CONFIGARGS?=-g > line, which changed the gcc invocation to -O instead of the default -O2. > > Again, after playing around with the gcc options a bit, it turns out > that -O2 includes -funit-at-a-time, making gcc parse the whole cxgb_sge.c > before the compilation, so that it can see the refill_rspq() function > body and it can inline it properly. > > So... I'm not sure what the proper solution ought to be - either figure > out a way to add -funit-at-a-time to CFLAGS (which might not work all > that well with non-gcc compilers, I guess), or move the function body up > as per my original suggestion. > > G'luck, > Peter > > -- > Peter Pentchev roam@ringlet.net roam@cnsys.bg roam@FreeBSD.org > PGP key: http://people.FreeBSD.org/~roam/roam.key.asc > Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 > I had to translate this sentence into English because I could not read the > original Sanskrit. >