From owner-svn-src-head@freebsd.org Sun Oct 1 20:36:22 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CAC3EE2DFAB; Sun, 1 Oct 2017 20:36:22 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 249A16DF72; Sun, 1 Oct 2017 20:36:19 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id XAA07125; Sun, 01 Oct 2017 23:36:11 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1dykyB-000IeD-IT; Sun, 01 Oct 2017 23:36:11 +0300 Subject: Re: svn commit: r324163 - in head: cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd/zpool cddl/contrib/opensolaris/lib/libzfs/common cddl/contrib/opensolaris/lib/libzfs_core/common cddl/co... To: Ian Lepore , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201710011611.v91GB8LM024101@repo.freebsd.org> <1506877870.22078.28.camel@freebsd.org> From: Andriy Gapon Message-ID: <61cbd210-a316-5f29-ce52-da40e4added5@FreeBSD.org> Date: Sun, 1 Oct 2017 23:35:14 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1506877870.22078.28.camel@freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 20:36:22 -0000 On 01/10/2017 20:11, Ian Lepore wrote: > On Sun, 2017-10-01 at 16:11 +0000, Andriy Gapon wrote: >> Author: avg >> Date: Sun Oct  1 16:11:07 2017 >> New Revision: 324163 >> URL: https://svnweb.freebsd.org/changeset/base/324163 >> >> Log: >>   MFV r323530,r323533,r323534: 7431 ZFS Channel Programs, and >> followups >>    > > Powerpc and sparc builds are dying on: > > src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c:870: > warning: comparison is always true due to limited range of data type > > "(unsigned char)anything >= 0" is also always true on clang, so I'm not > sure why it doesn't warn too. That's what I get for forgetting that other architectures use ZFS as well and, thus, not building universe. I've just committed a naive / trivial fix. Seems like there was just a single problem and not a systemic issue. Thank you for the report! -- Andriy Gapon