From owner-cvs-all Sun Jul 16 15:54:22 2000 Delivered-To: cvs-all@freebsd.org Received: from netplex.com.au (adsl-63-207-30-186.dsl.snfc21.pacbell.net [63.207.30.186]) by hub.freebsd.org (Postfix) with ESMTP id D57BC37B59D; Sun, 16 Jul 2000 15:54:10 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (peter@localhost [127.0.0.1]) by netplex.com.au (8.9.3/8.9.3) with ESMTP id PAA26426; Sun, 16 Jul 2000 15:54:07 -0700 (PDT) (envelope-from peter@netplex.com.au) Message-Id: <200007162254.PAA26426@netplex.com.au> X-Mailer: exmh version 2.1.1 10/15/1999 To: Matt Dillon Cc: "Jordan K. Hubbard" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/usbd usbd.c In-Reply-To: Message from Matt Dillon of "Sun, 16 Jul 2000 15:48:53 PDT." <200007162248.PAA09181@earth.backplane.com> Date: Sun, 16 Jul 2000 15:54:07 -0700 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Matt Dillon wrote: > > :> Correct an additional off-by-one bug and buffer overflow. A malloc() > :> was being made one byte too short, and the string assembled in it was no t > :> null terminated. The string was passed to regcomp() so it never matched > :> anything in /etc/usbd.conf. This is the cause of usbd not working for t he > :> last few days.. The new malloc.conf default of AJ triggered this. > : > :Oh god, did you have to say that? Now phk will be INSUFFERABLE for > :weeks. :-) > : > :- Jordan > > AJ ? Guys, 'J' as a default to malloc.conf is a disaster for performance . > There are many programs which allocate large buffers and only use > small portions of them. We *CANNOT* ship with 'J' as a default > for malloc. > > 'A', ok. 'AH' is even better. 'AJ'? no way. AJ is only going to be on for the development cycle. Once we hit -stable and/or the leadup to -release it will go back off. Incidently, I'd half like $MALLOC_OPTIONS set to 'aj' exported from Makefile so that the builds don't take as long. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message