Date: Sun, 23 Dec 2001 13:31:56 +1030 From: Greg Lehey <grog@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au>, Matthew Dillon <dillon@apollo.backplane.com>, Bruce Evans <bde@FreeBSD.org>, Matt Dillon <dillon@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, FreeBSD Core Team <core@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/sio sio.c Message-ID: <20011223133156.I88202@monorchid.lemis.com> In-Reply-To: <200112230248.fBN2mPE46699@freefall.freebsd.org> <200112230238.fBN2c4P45953@freefall.freebsd.org> <200112230242.fBN2gqh99138@apollo.backplane.com> <20011223132947.K10139-100000@gamplex.bde.org> References: <200112230248.fBN2mPE46699@freefall.freebsd.org> <200112230238.fBN2c4P45953@freefall.freebsd.org> <20011223132947.K10139-100000@gamplex.bde.org> <200112230242.fBN2gqh99138@apollo.backplane.com> <200112230048.fBN0mb624793@freefall.freebsd.org> <20011223132947.K10139-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
(dons -core hat) Come on, people, this isn't appropriate behaviour. I'd have expected a more mature approach from both of you. Please don't touch these sources until we've had time to talk about it (which probably means at least 24 hours). Greg On Sunday, 23 December 2001 at 13:33:53 +1100, Bruce Evans wrote: > On Sat, 22 Dec 2001, Matt Dillon wrote: > >> dillon 2001/12/22 16:48:37 PST >> >> Modified files: >> sys/dev/sio sio.c >> Log: >> This problem has been in the serial driver for years, and I occassionally >> see people trip over it. Do not set the FIFO trigger to just before it >> would otherwise overflow. Give it a little more slop so characters aren't >> lost if the interrupt is delayed by other system activities. >> >> MFC maybe: 7 days >> >> Revision Changes Path >> 1.354 +6 -1 src/sys/dev/sio/sio.c > > This setting is intentional. The default setting provides twice as much > slop as the 8250 UARTs which the driver was designed to support on systems > hundreds of times slower than current ones. Making it twice as large > again doesn't help much. > > This commit will was not approved or even sent for review to the maintainer > and will be backed out in a minute. > > Bruce On Saturday, 22 December 2001 at 18:42:52 -0800, Matthew Dillon wrote: >> >> This setting is intentional. The default setting provides twice as much >> slop as the 8250 UARTs which the driver was designed to support on systems >> hundreds of times slower than current ones. Making it twice as large >> again doesn't help much. >> >> This commit will was not approved or even sent for review to the maintainer >> and will be backed out in a minute. >> >> Bruce > > If you back it out I will put it right back in. You will need a core > action to take it out. Three people (inclusive of me) have had this > problem. People have had this problem before. People have had this > problem for YEARS. This fixed it for one, a second just emailed me > and said he had to do exactly the same thing, and I've had this problem > before to and this fixed it for me. > > If you want to go back to HI, you can damn well FIX all the problems > people are having with it in the first place. Otherwise it stays > at MEDHI. > > -Matt > Matthew Dillon > <dillon@backplane.com> On Saturday, 22 December 2001 at 18:38:04 -0800, Bruce Evans wrote: > bde 2001/12/22 18:38:04 PST > > Modified files: > sys/dev/sio sio.c > Log: > Backed out previous unapproved commit. > > Revision Changes Path > 1.355 +1 -6 src/sys/dev/sio/sio.c On Saturday, 22 December 2001 at 18:48:25 -0800, Matt Dillon wrote: > dillon 2001/12/22 18:48:25 PST > > Modified files: > sys/dev/sio sio.c > Log: > Back out an inappropriate backout. If Anyone wants to set the FIFO > level that high they should first fix the problems with the system that > cause silo overflows. It is far more important for the serial device > to work. > > Revision Changes Path > 1.356 +6 -1 src/sys/dev/sio/sio.c -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011223133156.I88202>