From owner-freebsd-hackers@FreeBSD.ORG Thu Nov 27 05:46:19 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B9E4106564A for ; Thu, 27 Nov 2008 05:46:19 +0000 (UTC) (envelope-from eitanadlerlist@gmail.com) Received: from mail-gx0-f12.google.com (mail-gx0-f12.google.com [209.85.217.12]) by mx1.freebsd.org (Postfix) with ESMTP id C5AEB8FC16 for ; Thu, 27 Nov 2008 05:46:18 +0000 (UTC) (envelope-from eitanadlerlist@gmail.com) Received: by gxk5 with SMTP id 5so810800gxk.19 for ; Wed, 26 Nov 2008 21:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:user-agent :mime-version:to:subject:references:in-reply-to:x-enigmail-version :openpgp:content-type:content-transfer-encoding:from; bh=XyIMYTU0ViIxkJFMAc8JjhjUwUr9oHl4nzisY4+tqUY=; b=Nm0SzmELh5O62WYPSIBEO/xW/7caPASgWk3fRh9e/duu2OatCUO3PTVSBZSgJkZLIq a0d1lOdH450t/0liF0IiQArGfDj8Mgi+ThDSUnv5iHbl0pXfKBwqOJa3MbeckA9A/Ptu 4LA+MrLWsfuVobB+U15skZymSG4eeE725tu6s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:openpgp:content-type :content-transfer-encoding:from; b=E0TPwcUjIAVJylHDNtvUeadEM2H+OpZtVYCv893aDS4jKQXL6wHhEzHw0dEcX5La94 SB5SlHhA/hd9nceVYMEffc5y6VilfvgfjiApDU5E8tXxTBXLb8YMtD53VOYhiRAN3Da7 mPBn2sD6Cr7ZVwUmmaZ+lfwz5dIWj4q5OATMI= Received: by 10.90.98.12 with SMTP id v12mr3827372agb.64.1227764777577; Wed, 26 Nov 2008 21:46:17 -0800 (PST) Received: from ?192.168.1.101? (ool-182d26f3.dyn.optonline.net [24.45.38.243]) by mx.google.com with ESMTPS id 18sm1175564agb.12.2008.11.26.21.46.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 26 Nov 2008 21:46:16 -0800 (PST) Message-ID: <492E3424.4080109@gmail.com> Date: Thu, 27 Nov 2008 00:46:12 -0500 User-Agent: Mozilla (X11; U; FreeBSD i386; en-US; ) Gecko Thunderbird Mnenhy/0.7.5.666 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org References: <87vdueavft.fsf@h1.lan> <20081124084016.GA1384@lizard.fafoe.narf.at> In-Reply-To: <20081124084016.GA1384@lizard.fafoe.narf.at> X-Enigmail-Version: 0.95.7 OpenPGP: id=E9C2CCD1; url=pgp.mit.edu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Eitan Adler Subject: Re: `type' built-in command in /bin/sh X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2008 05:46:19 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stefan Farfeleder wrote: > On Mon, Nov 24, 2008 at 02:12:22AM +0300, Zajcev Evgeny wrote: >> Hello there. I just hit into "problem" that built-in sh command type >> outputs to stdout when error occurs. I mean it returns non-0 status, >> but outputs to stdout! I think stderr has been made exactly for such >> purposes and `type' should use it in case of error .. what do you >> think? As far as I could tell if (cmd != TYPECMD_SMALLV) out1str(": not found\n"); has to be changed to if (cmd != TYPECMD_SMALLV) out2str(": not found\n"); C is not my strongest language so please let me know if I am correct. - -- Eitan Adler GNU Key fingerptrint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkkuNCQACgkQtl8kq+nCzNGrGgCfZu5MHngEnMyQ5X+g1ZtKraJu blsAn3xoReD4+mVYU5Agw3Ns5CyIIO+p =0cXm -----END PGP SIGNATURE-----