Date: Mon, 11 Apr 2016 09:56:05 +0800 From: Sepherosa Ziehau <sephe@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297699 - head/sys/dev/hyperv/vmbus Message-ID: <CAMOc5cz4STgoE4exN8N7nw1ic__U9mouzsS_xgWa%2Bx62qL7U7Q@mail.gmail.com> In-Reply-To: <2723235.iE8LVQdaEH@ralph.baldwin.cx> References: <201604080920.u389KliR048702@repo.freebsd.org> <2723235.iE8LVQdaEH@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 8, 2016 at 10:50 PM, John Baldwin <jhb@freebsd.org> wrote: > On Friday, April 08, 2016 09:20:47 AM Sepherosa Ziehau wrote: >> Author: sephe >> Date: Fri Apr 8 09:20:46 2016 >> New Revision: 297699 >> URL: https://svnweb.freebsd.org/changeset/base/297699 >> >> Log: >> hyperv: Revert r297481 >> >> Use vm_guest == VM_GUEST_HV is not enough to determine whether FreeBSD >> is running on Hyper-V or not. What a mess. >> >> Reported by: smokehydration tutanota com >> Sponsored by: Microsoft OSTC > > Ewww, does this mean Hyper-V doesn't always report itself via the VM > CPUID leafs? (Or is it not setting the HV cpuid feature bit?) Some other hypervisors reuse Hyper-V's ID. So relying on the ID==Hyper-V is not going to work. We have a patch to do more cpuids to detect the existence of the Hyper-V time counter and other bits (event timer, etc), which do not hooked to the vmbus. Thanks, sephe -- Tomorrow Will Never Die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMOc5cz4STgoE4exN8N7nw1ic__U9mouzsS_xgWa%2Bx62qL7U7Q>