From owner-svn-ports-all@FreeBSD.ORG  Wed Apr 24 19:14:45 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@FreeBSD.org
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by hub.freebsd.org (Postfix) with ESMTP id 3D315F26;
 Wed, 24 Apr 2013 19:14:45 +0000 (UTC)
 (envelope-from jkim@FreeBSD.org)
Message-ID: <51782E72.20605@FreeBSD.org>
Date: Wed, 24 Apr 2013 15:11:46 -0400
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130408 Thunderbird/17.0.5
MIME-Version: 1.0
To: Chris Rees <crees@FreeBSD.org>
Subject: Re: svn commit: r316469 - head/databases/slony1v2
References: <201304241850.r3OIovPc079999@svn.freebsd.org>
 <51782B87.2090000@FreeBSD.org>
 <CADLo839thOhg3xF2v_vEggbDiK6dTGr7m9SHyEV8NtR5VFY+mA@mail.gmail.com>
In-Reply-To: <CADLo839thOhg3xF2v_vEggbDiK6dTGr7m9SHyEV8NtR5VFY+mA@mail.gmail.com>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@FreeBSD.org>,
 svn-ports-all@FreeBSD.org, Jimmy Olgeni <olgeni@FreeBSD.org>,
 "ports-committers@freebsd.org" <ports-committers@FreeBSD.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Apr 2013 19:14:45 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-04-24 15:06:31 -0400, Chris Rees wrote:
> On 24 April 2013 19:59, Jung-uk Kim <jkim@freebsd.org> wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> 
>> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote:
>>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New Revision:
>>> 316469 URL: http://svnweb.freebsd.org/changeset/ports/316469
>>> 
>>> Log: - Use bsd.port.options.mk. - PORTDOCS should not be 
>>> conditional. - Whitespace fix.
>> ...
>> 
>> bsd.port.mk says "(PORTDOCS) should not be set when no
>> documentation files are installed" and I believe it is actually
>> correct.
> 
> That means "Don't set PORTDOCS unless you are going to install
> files to DOCSDIR".
> 
> This port does install files to DOCSDIR, except when !
> ${PORT_OPTIONS:MDOCS}

Therefore, it should be conditional. :-)

If you convert NOPORTDOCS to optionsNG, it should be optional because
bsd.port.mk does not know that, i.e.,

.if defined(PORTDOCS) && !defined(NOPORTDOCS)
...
.endif

Maybe we should fix bsd.port.mk, too.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iQEcBAEBAgAGBQJReC5yAAoJECXpabHZMqHOdywH/j+kPX2wL/ZIKXiuRMFRL51g
ch6noFBm7v43JuntoDqbp6NbTrB7Eq/Plno08nfmycE9OiBKtrOxM9k6wQ6OseTf
f5jbaU5vNmm4RfxUV1DfSFQd7nIfKTa38C1zrzDH3nr+SIMxe+nbu1nj7meJQQId
enABe1HykaUqrwkwgvuJmAW+XqxsJGlTjMDIdr6i9XK5ozEveE9RnMIraK+PULmo
aqypGG48Kj3flKMSzR6HyiVBuFSG4VVOVekXohG0AWDrtlm7zE5YhF8JYlDvglk1
jC4sFTCLiKRf3K93CkYpLp5Dtwa/e14sRfZz4Jn9dFLV861QJIl8Hy7o652/gb4=
=7/r2
-----END PGP SIGNATURE-----