From owner-svn-src-head@freebsd.org Sat Jan 16 02:26:51 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D438AA83F00; Sat, 16 Jan 2016 02:26:51 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x229.google.com (mail-pf0-x229.google.com [IPv6:2607:f8b0:400e:c00::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A6330113B; Sat, 16 Jan 2016 02:26:51 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x229.google.com with SMTP id q63so130327179pfb.1; Fri, 15 Jan 2016 18:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/ZPLTvep2m0VBQb1fxSWnB+0kUyE+17UFXAJjrMCInI=; b=xqNnC0CwFkd4YzrjmOrVBOdGZ/zhi0hQS0z9D/lI8wSXpovbsqLj9Pk4qaCoASAGZM C5VmKZIJprr+gjM2FMW9K5h1Vy6+7Ti2g+vccBGIlcLAhySqUQHJHArn/D7cekYjSjHI TrpXrzBESd070rwPo5P91IX0kcY650XvE0OUDXmFC09H67pWP99bsN8oVzspw7HDcn+2 uB/wLzWRZaIw8Xj2QWjcD7nLo/ymnS568RFK5GvCmsaJYXqGAjytr4nHnBBbEIaNcmhL hno685DxzI7vEGcGNXI+5x9ruIHytFgGmlI9igb8owwYuk65JVNxuSNdX+ldpIOZUX1z McJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=/ZPLTvep2m0VBQb1fxSWnB+0kUyE+17UFXAJjrMCInI=; b=kLlAjxWozm0POF81s3QLXQtubDleYhH8zwMpusfjVW61V3slfYtdpUcoDwNEDS08xM pD2Z1hKzK5BOE5kDupXLSRodIxB2jXb/YURV7r5o6MYjW8AWSwkKUS+rO91UjCxEeynH o1AgwKZ+rYLzAb1UsDnzsrq1Y2PsgXC0j6AjqPWoihNcu6Zvomgq1FMO2+nm58e98q7H mnH6aH+Q26yiT4jCvHWNKvghU1RqlkJDWVg8ffxxLD/GB8BSpx62rgh/mwosObC4VkgS SWLtCT4gRmRiRkYfvFH7WwoHrywjjuE/IxE1DfmsOhtAO6YSayC6SXU2aOLp+nTWBWLx eHlA== X-Gm-Message-State: ALoCoQmT8JAkKAC7Kzi/3OdYEOHUUlANtipWHrAJJNZj9D1mmqRzb8eUJgrrgBAc6JrsMeWKiXalYyBUVMigfkHX0SL3UeIG3Q== X-Received: by 10.98.42.135 with SMTP id q129mr19384238pfq.13.1452911211301; Fri, 15 Jan 2016 18:26:51 -0800 (PST) Received: from [192.168.100.136] ([199.231.240.59]) by smtp.gmail.com with ESMTPSA id g87sm18237104pfj.1.2016.01.15.18.26.49 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 15 Jan 2016 18:26:49 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r294127 - head/tools/regression/sockets/zerosend From: NGie Cooper In-Reply-To: <5699A94A.8070209@multiplay.co.uk> Date: Fri, 15 Jan 2016 18:26:49 -0800 Cc: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <740B6378-A27E-43DA-BC24-293A672355AC@gmail.com> References: <201601160218.u0G2IaRW066902@repo.freebsd.org> <5699A94A.8070209@multiplay.co.uk> To: Steven Hartland X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jan 2016 02:26:51 -0000 > On Jan 15, 2016, at 18:22, Steven Hartland = wrote: >=20 > The main params change seems a bit odd, wouldn't have expected that to = be valid, shouldn't they just be flagged __unused? `int main(void)` is an acceptable function definition in ANSI C =E2=80=94 = I don=E2=80=99t see why adding __unused should be done. $ grep arg tools/regression/sockets/zerosend/zerosend.c || echo not = found not found The next step is to convert these tests over to ATF, but I wanted to fix = all of the warnings/issues so I could backport them to stable/9, then = convert them to ATF. Thanks! -NGie=