From owner-svn-ports-head@FreeBSD.ORG Thu May 30 18:38:32 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3102E7BB; Thu, 30 May 2013 18:38:32 +0000 (UTC) (envelope-from bf1783@googlemail.com) Received: from mail-ie0-x235.google.com (mail-ie0-x235.google.com [IPv6:2607:f8b0:4001:c03::235]) by mx1.freebsd.org (Postfix) with ESMTP id D36DCCD4; Thu, 30 May 2013 18:38:31 +0000 (UTC) Received: by mail-ie0-f181.google.com with SMTP id x14so1422093ief.26 for ; Thu, 30 May 2013 11:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=XxKoAiYJsTWJOrB4KH+4wqCgYryLO9ugpW8IO/YxoRc=; b=ajvNmQWIqzRYzgiFYy2U+UOHZM3Ow5pjmcXnudwlDuMVodtQFoFtJ7reTGEgA4ch0q Sxv7LP874MbgqA4qED6CK2UXisG8U4It86MdpcstMwKIpaErXKNfhxLiO1d8WjpIVJ5F hgfzRLWUCmKn4D7NyYUe58DagrAqJ3dBVqDSYq3Ryu6t0tvrjG4GCG6MympAE5jOPPcX qXRv3d5Kx5bA0FhVSLiqa790MgFsvVPfc7QKokgyLQAcXXvozudHWaYtjhfzczGuSQd+ EBDcmrQFsnSjNAU2ycJwBBjVdv8ok4xVYEz2kuF6N8QUYHK6of5E/ed0UuguneyO5rKY r2Kw== MIME-Version: 1.0 X-Received: by 10.50.66.199 with SMTP id h7mr43308igt.8.1369939111509; Thu, 30 May 2013 11:38:31 -0700 (PDT) Received: by 10.64.39.201 with HTTP; Thu, 30 May 2013 11:38:31 -0700 (PDT) In-Reply-To: References: <201305291541.r4TFf1PO037359@svn.freebsd.org> Date: Thu, 30 May 2013 14:38:31 -0400 Message-ID: Subject: Re: svn commit: r319380 - head/math/libtommath From: "b.f." To: Eitan Adler Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Martin Wilke X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: bf1783@gmail.com List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 May 2013 18:38:32 -0000 On 5/30/13, Eitan Adler wrote: > On 30 May 2013 19:47, b.f. wrote: >> On 5/30/13, Eitan Adler wrote: >>> On 30 May 2013 03:42, Martin Wilke wrote: >>>> >>>> On May 30, 2013, at 5:17 AM, Eitan Adler wrote: >>>> >>>>> On 29 May 2013 17:41, Martin Wilke wrote: >>>>>> Author: miwi >>>>>> Date: Wed May 29 15:41:00 2013 >>>>>> New Revision: 319380 >>>>>> URL: http://svnweb.freebsd.org/changeset/ports/319380 >>>>>> >>>>>> Log: >>>>>> - Disable regression test >>>>>> >>>>>> Reported by: pointyhat building 2(D)-02:56:27 >>>>> >>>>> This doesn't really explain what happened here. >>>>> Did the regression test fail? Did the tests fail to build? Are there >>>>> no regression tests? >>>>> >>>>> If the tests failed are they false positives, or do they indicate >>>>> actual problems (where the port should be marked BROKEN)? >>>>> >>>> >>>> the regression test hangs without timeout thats why i have disable it. >>>> port it self builds fine no reason to mark it broken. >>> >>> Do the hangs indicate failure of the test program or failure of the >>> actual program? >>> If the latter it should be marked BROKEN. >> >> We don't automatically mark ports as BROKEN if they fail to pass a >> test -- if we did, a great many more ports would be unavailable, >> because most ports don't perform perfectly. Often test failures are >> caused by the conditions in which the tests are run, or are due to >> problems in the testsuite, or represent uncommon or minor problems >> that should ultimately be fixed, but don't render the port useless in >> the meantime. > > Please read what I asked carefully. > > Is the failure an indication of a broken program? > > BROKEN is not used just because a port fails its regression tests but > it isn't reserved just for build failures. Of course it isn't. My point was that even if the test failure indicated a "failure of the actual program", it doesn't necessarily mean that the port should be marked BROKEN, as you seemed to suggest. It depends on the nature of the failure. b.