From owner-svn-ports-head@FreeBSD.ORG  Wed Apr 24 19:24:54 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by hub.freebsd.org (Postfix) with ESMTP id D8A69764;
 Wed, 24 Apr 2013 19:24:53 +0000 (UTC)
 (envelope-from jkim@FreeBSD.org)
Message-ID: <517830D2.5060600@FreeBSD.org>
Date: Wed, 24 Apr 2013 15:21:54 -0400
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130408 Thunderbird/17.0.5
MIME-Version: 1.0
To: Jimmy Olgeni <olgeni@freebsd.org>
Subject: Re: svn commit: r316469 - head/databases/slony1v2
References: <201304241850.r3OIovPc079999@svn.freebsd.org>
 <51782B87.2090000@FreeBSD.org>
 <alpine.BSF.2.00.1304242105250.29749@olgeni.olgeni>
In-Reply-To: <alpine.BSF.2.00.1304242105250.29749@olgeni.olgeni>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Apr 2013 19:24:54 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-04-24 15:08:00 -0400, Jimmy Olgeni wrote:
> 
> On Wed, 24 Apr 2013, Jung-uk Kim wrote:
> 
>> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote:
>>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New Revision:
>>> 316469 URL: http://svnweb.freebsd.org/changeset/ports/316469
>>> 
>>> Log: - Use bsd.port.options.mk. - PORTDOCS should not be 
>>> conditional. - Whitespace fix.
>> ...
>> 
>> bsd.port.mk says "(PORTDOCS) should not be set when no
>> documentation files are installed" and I believe it is actually
>> correct.
> 
> I found this on the Porter's Handbook:
> 
> If a directory is listed in PORTDOCS or matched by a glob pattern 
> from this variable, the entire subtree of contained files and 
> directories will be registered in the final packing list. If the
> DOCS option has been unset then files and directories listed in
> PORTDOCS would not be installed or added to port packing list.
> 
> It seems to behave correctly, at least in the PORTDOCS=* case.

It may work for now because bsd.options.mk has backward compat shim, i.e.,

## Now some compatibility
.if empty(PORT_OPTIONS:MDOCS)
NOPORTDOCS=     yes
.endif

It won't work when we deprecate the compat shims.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iQEcBAEBAgAGBQJReDDSAAoJECXpabHZMqHOeMwIAM1VyJVz0QZCBHLZtxOgZPPN
Pc5rAVb7NFzN6bh50MjmbM5zHZPzM/0zuGtqRu059TlfAmABJBJqrjhPkcnHHGHX
coWBKZdOnGwhzaCGFU8SsVvntbyIQX1wO7OMkUbvDGnP/HLvBTQ0ybw81GOUa5Tz
921d0W1ZLTPIfonviV1H2TQWo+8Kbeh8/9H9IsQsJtQzqbh4rPzatiujEYuIIuqx
GBjUAPOmuGQSrh3tmpvA19O4l0KjsVt2re5I8numPPwIhPWWCgPi7pTAEHLre5IW
o7GyF9lu4zVZhjVz67HW5XT3mb0ZR0BeaBi61i2C6Q2DrZhywmM7DaKH4qsbcSc=
=PWBI
-----END PGP SIGNATURE-----