Date: Thu, 19 Oct 2017 16:28:59 -0400 From: Steve Wills <swills@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Shane <FreeBSD@ShaneWare.Biz>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r452419 - in head/graphics: . ptex ptex/files Message-ID: <1405827a-df6f-26fb-f769-c42cd77ba101@FreeBSD.org> In-Reply-To: <fuaf-c90s-wny@FreeBSD.org> References: <201710191310.v9JDAmdQ047764@repo.freebsd.org> <fuaf-c90s-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On 10/19/2017 14:00, Jan Beich wrote:
> Steve Wills <swills@FreeBSD.org> writes:
>
>> +PORTNAME= ptex
> [...]
>> +GH_PROJECT= ptex
>
> One of these is redundant.
>
>> +PORTVERSION= 2.1.28
>> +GH_TAGNAME= v${PORTVERSION}
>
> Use DISTVERSIONPREFIX.
>
> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex3
>
Yeah, sorry, I should have looked closer at these.
>> +DOCS_BUILD_DEPENDS= doxygen:devel/doxygen
>
> Maybe rename to DOXYGEN, so users can disable it globally via OPTIONS_UNSET.
> DOCS is enabled by default, so you may want to enable DOXYGEN as well.
>
> https://lists.freebsd.org/pipermail/freebsd-ports/2015-March/098258.html
> https://svnweb.freebsd.org/changeset/ports/428947
> https://svnweb.freebsd.org/changeset/ports/429005
> https://svnweb.freebsd.org/changeset/ports/429007
> https://svnweb.freebsd.org/changeset/ports/429087
> https://svnweb.freebsd.org/changeset/ports/429088
> https://svnweb.freebsd.org/changeset/ports/429089
> https://svnweb.freebsd.org/changeset/ports/429090
> https://svnweb.freebsd.org/changeset/ports/429091
> https://svnweb.freebsd.org/changeset/ports/429092
> https://svnweb.freebsd.org/changeset/ports/429093
> https://svnweb.freebsd.org/changeset/ports/429094
> https://svnweb.freebsd.org/changeset/ports/429095
> https://svnweb.freebsd.org/changeset/ports/429096
> https://svnweb.freebsd.org/changeset/ports/429098
> https://svnweb.freebsd.org/changeset/ports/429099
> https://svnweb.freebsd.org/changeset/ports/429228 (reverts r429099)
> https://svnweb.freebsd.org/changeset/ports/429229 (reverts r429097)
>
I'll have to look at this more, but right now I'm leaning against making
a special case just because the docs are built with Doxygen. (Yes, the
ruby ports have it, but they also have other docs, so the doxygen docs
there are more like "additional docs" and aren't really that useful.)
>> +.include <bsd.port.options.mk>
>
> Unused line. Nothing later uses .if/.for conditionals.
>
Ok, that makes sense.
>> ++#if !defined(__FreeBSD__)
>> + #include <alloca.h>
>> ++#endif
>
> None of BSDs have <alloca.h>, including DragonFly which is a downstream
> consumer of FreeBSD Ports.
>
Right, hence not including it if __FreeBSD__ is defined. What change are
you looking for?
Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1405827a-df6f-26fb-f769-c42cd77ba101>