Date: Wed, 19 Aug 2015 17:38:13 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r394782 - head/games/dangen Message-ID: <BD70EA7A9B0DE021CB7BF1BB@atuin.in.mat.cc> In-Reply-To: <20150819155543.GB42382@hades.panopticon> References: <201508191358.t7JDw7aV062421@repo.freebsd.org> <BC758709A8CCB114B14581F0@atuin.in.mat.cc> <20150819155543.GB42382@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========2DB5BEDE198E78EF015E==========
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
+--On 19 ao=C3=BBt 2015 18:55:43 +0300 Dmitry Marakasov <amdmi3@amdmi3.ru>
wrote:
| * Mathieu Arnold (mat@FreeBSD.org) wrote:
|> +--On 19 ao=C3=BBt 2015 13:58:07 +0000 Dmitry Marakasov =
<amdmi3@FreeBSD.org>
|> wrote:
|> | =20
|> | -.include <bsd.port.options.mk>
|> | -
|> | post-install:
|> | -.if ${PORT_OPTIONS:MDOCS}
|> | ${MKDIR} ${STAGEDIR}${DOCSDIR}
|> | ${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}/
|> | -.endif
|>=20
|> This bit was not part of the commit message, which is bad :-)
|=20
| I thought of it as too minor to mention.
|=20
|> Having said that, you can now use the post-install-DOCS-on target in
|> there, it will only run when the DOCS option is enabled.
|=20
| Oh, thanks for reminding! I guess I'll adopt more of that in my
| ports. Could you suggest a meaningful commit message for such
| changes? "Use conditional targets"?
Use option helpers, or use option specific target, see what I did in
r394778.
--=20
Mathieu Arnold
--==========2DB5BEDE198E78EF015E==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJV1LD2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I+WEQAJcUARSqpAF28K9x5YJY9JY+
r3Ih3uwwoRmAwIdKyV0ZYQ/a4ksbhyUJNfQUuQQEr0/6VcL7TNxCbC4OiJPtUm8c
0Cz7cmDnDNnaHBQ1DIUmIe3JvK//F88xrahGSTq3Gr1x+ho9NT0Jq5pDQ5jCALQ7
Y7QfEr0b0O4P/5C9LU363yMCbh4BeyOLeenJyWJGmM53cU8MuXLwsXCS1J6qDVgX
n8wxkR4ePxTwsajtHS1Z0Td8udgsJgz7CyIK1xqDnWFsD4VukRwk4hZZ3yUT9ZOU
S0WwYetEqLiYvi8qvCRIW0O85yhJWs8ad3BJXiUZYeghCjg5Qow7hHkaULmmXWRS
wfHKUb9PCLZAXhDuigsSCxchUSws+MUglZXuda10+cZpBhsFAl1V+ZcDyJkU91WR
FwyLkZpscFq8qKM9hQmqhBEhpX/MOZPhTFsWoezm2IEumKp+ll50TnJHxNi+qIxp
OM3nTCTCMcmsSH79ET243TVhRlifxq/MtrwiGkaPXvlyVRNN5hmukBEK0MtjKE+R
HHG19RGdMfQPM6duROm4QbNdmPQTOYA5GDaKyzY34Do0oYw0xgwoh8jIxYcGLpM1
KtcmIUcgXZ53xXgdIhlmgyBo+QMnI6XImGfu7abGamd6DxmfKnrHI+zaRXHYCiJY
StkhKx9BRk37gj+eeXFa
=YFQV
-----END PGP SIGNATURE-----
--==========2DB5BEDE198E78EF015E==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BD70EA7A9B0DE021CB7BF1BB>