From owner-freebsd-ports Sun Apr 20 12:53:11 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA09874 for ports-outgoing; Sun, 20 Apr 1997 12:53:11 -0700 (PDT) Received: from nexis.net (customer-1.ican.net [198.133.36.101]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA09775; Sun, 20 Apr 1997 12:52:38 -0700 (PDT) Received: from localhost (james@localhost) by nexis.net (8.8.5/8.8.5) with SMTP id PAA14628; Sun, 20 Apr 1997 15:48:21 -0400 (EDT) Date: Sun, 20 Apr 1997 15:48:19 -0400 (EDT) From: James FitzGibbon To: jhs@freebsd.org cc: FreeBSD-gnats-submit@freebsd.org, me@freebsd.org, gj@freebsd.org, asami@freebsd.org, GNATS Management , freebsd-ports@freefall.freebsd.org Subject: Re: ports/3361: patch for bsd.port.mk In-Reply-To: <199704201840.UAA02676@wall.jhs.no_domain> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Sun, 20 Apr 1997 jhs@freebsd.org wrote: > + MASTER_SITES:= ${NEARBY_DISTFILES_SITE}/ ${MASTER_SITES} > + PATCH_SITES:= ${NEARBY_DISTFILES_SITE}/ ${MASTER_SITES} > + .endif Sounds like a good idea, but doesn't MASTER_SITE_OVERRIDE already do this ? .if !defined(MASTER_SITE_OVERRIDE) MASTER_SITES+= ${MASTER_SITE_BACKUP} PATCH_SITES+= ${MASTER_SITE_BACKUP} .else MASTER_SITES:= ${MASTER_SITE_OVERRIDE} ${MASTER_SITES} PATCH_SITES:= ${MASTER_SITE_OVERRIDE} ${PATCH_SITES} .endif ${MASTER_SITE_OVERRIDE} doesn't (as I once thought) override ${MASTER_SITES}, it just prepends the one you name to the defined list. -- j.