From owner-cvs-all@FreeBSD.ORG Fri Jun 25 10:31:57 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E967516A4CE; Fri, 25 Jun 2004 10:31:56 +0000 (GMT) Received: from web.portaone.com (mail.russia.cz [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id F413F43D2D; Fri, 25 Jun 2004 10:31:55 +0000 (GMT) (envelope-from sobomax@portaone.com) Received: from portaone.com (localhost [127.0.0.1]) (authenticated bits=0) by web.portaone.com (8.12.8p2/8.12.8) with ESMTP id i5PAUhAv024597; Fri, 25 Jun 2004 12:30:44 +0200 (CEST) (envelope-from sobomax@portaone.com) Message-ID: <40DBFECC.7010201@portaone.com> Date: Fri, 25 Jun 2004 13:30:36 +0300 From: Maxim Sobolev User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 (ax) X-Accept-Language: en-us, en, ru, uk MIME-Version: 1.0 To: Makoto Matsushita References: <200406231901.i5NJ1w4s010295@repoman.freebsd.org> <40DADB5A.3010906@portaone.com> <20040625092836L.matusita@jp.FreeBSD.org> In-Reply-To: <20040625092836L.matusita@jp.FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-ports@FreeBSD.ORG cc: matusita@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: ports-committers@FreeBSD.ORG Subject: Re: cvs commit: ports/emulators/linux-vmware-toolbox4 Makefile ports/emulators/vmware-guestd4 Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jun 2004 10:31:57 -0000 Makoto Matsushita wrote: > sobomax> I've found that attached patch is required on latest > sobomax> -current, otherwise os.o isn't linked into .ko as a result it > sobomax> can't be loaded due to missed os_*() functions. Please either > sobomax> commit it by yourself or give me permissions to do it. > > At least on my 5-current box as of Jun/23/2004, there's zero > difference between 'OBJS=' case and 'OBJS+=' case (read: "make -V > OBJS" returns the same result on both cases). > > Would you please enlighten me? See the following log. As you can see, ld(1) is invoked without os.o: ld -d -warn-common -r -d -o vmmemctl.kld vmmemctl1.o -Maxim root@notebook# VERBOSE=1 make ===> Vulnerability check disabled ======================================================================== Choose "VM" -> "Install VMware Tools..." from the Workstation menu to connect the VM's CD-ROM drive temporarily to installation CD image. ======================================================================== This port mounts /dev/acd0 to /mnt. Are you ready? [Y/n]: /bin/mkdir -p /mnt /sbin/umount /mnt 2>&1 >/dev/null umount: /mnt: not a file system root directory *** Error code 1 (ignored) /sbin/umount /dev/acd0 2>&1 >/dev/null umount: /dev/acd0: unknown file system *** Error code 1 (ignored) /sbin/mount -t cd9660 /dev/acd0 /mnt ===> Extracting for vmware-guestd-4.5.2.8848_1 /sbin/umount /mnt (cd /tmp/portbuild/usr/ports/emulators/vmware-guestd4/work; /usr/bin/tar xf /tmp/portbuild/usr/ports/emulators/vmware-guestd4/work/vmware-tools-distrib/lib/modules/source/vmmemctl.tar) ===> Patching for vmware-guestd-4.5.2.8848_1 /usr/bin/sed -i.bak -e 's|vmmemctl1.o||' /tmp/portbuild/usr/ports/emulators/vmware-guestd4/work/vmmemctl-only/Makefile echo "OBJS=vmmemctl1.o" >> /tmp/portbuild/usr/ports/emulators/vmware-guestd4/work/vmmemctl-only/Makefile ===> Configuring for vmware-guestd-4.5.2.8848_1 ===> Building for vmware-guestd-4.5.2.8848_1 (cd /tmp/portbuild/usr/ports/emulators/vmware-guestd4/work/vmmemctl-only; make) @ -> /usr/src/sys machine -> /usr/src/sys/i386/include cc -O -pipe -march=pentium4 -D_KERNEL -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/contrib/altq -I@/../include -I/usr/include -finline-limit=8000 -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -c os.c ld -d -warn-common -r -d -o vmmemctl.kld vmmemctl1.o touch /tmp/portbuild/usr/ports/emulators/vmware-guestd4/work/vmmemctl-only/export_syms awk -f /sys/conf/kmod_syms.awk vmmemctl.kld /tmp/portbuild/usr/ports/emulators/vmware-guestd4/work/vmmemctl-only/export_syms | xargs -J% objcopy % vmmemctl.kld ld -Bshareable -d -warn-common -o vmmemctl.ko vmmemctl.kld objcopy --strip-debug vmmemctl.ko