From owner-freebsd-ports@FreeBSD.ORG Mon Jan 9 21:11:34 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 541A8106570C for ; Mon, 9 Jan 2012 21:11:34 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward20.mail.yandex.net (forward20.mail.yandex.net [IPv6:2a02:6b8:0:1402::5]) by mx1.freebsd.org (Postfix) with ESMTP id BF9CC8FC1E for ; Mon, 9 Jan 2012 21:11:33 +0000 (UTC) Received: from smtp17.mail.yandex.net (smtp17.mail.yandex.net [95.108.252.17]) by forward20.mail.yandex.net (Yandex) with ESMTP id C29771040AC9 for ; Tue, 10 Jan 2012 01:11:14 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1326143474; bh=5pjK10fru1V40RkMrwoFfMkt6Y5Qygo9u3UGhe6/FsQ=; h=Message-ID:Date:From:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=i1IJOv7pQ44ShOFnXq4QkwVp2t66YfxEX3SFhYs4L+GkY8fVsLqw7JAz/I8dde0+E caxLG/AnJmgD8FQnXCkyKiIQE/ybb9XPo9y5nY4E6TM2bYU0bSLsYLg8UL100eFfeO TSkEkvGCMf2XMVwZ/TSyPUCp8d0ZfYm2LmlyrIEY= Received: from smtp17.mail.yandex.net (localhost [127.0.0.1]) by smtp17.mail.yandex.net (Yandex) with ESMTP id AAAC51900199 for ; Tue, 10 Jan 2012 01:11:14 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1326143474; bh=5pjK10fru1V40RkMrwoFfMkt6Y5Qygo9u3UGhe6/FsQ=; h=Message-ID:Date:From:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=i1IJOv7pQ44ShOFnXq4QkwVp2t66YfxEX3SFhYs4L+GkY8fVsLqw7JAz/I8dde0+E caxLG/AnJmgD8FQnXCkyKiIQE/ybb9XPo9y5nY4E6TM2bYU0bSLsYLg8UL100eFfeO TSkEkvGCMf2XMVwZ/TSyPUCp8d0ZfYm2LmlyrIEY= Received: from unknown (unknown [178.76.224.133]) by smtp17.mail.yandex.net (nwsmtp/Yandex) with ESMTP id BDOmWWuk-BEO0P0oW; Tue, 10 Jan 2012 01:11:14 +0400 X-Yandex-Spam: 1 Message-ID: <4F0B57CC.5050909@yandex.ru> Date: Tue, 10 Jan 2012 01:10:36 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: ports@freebsd.org References: <4F0B4E5F.8040802@secnap.com> <4F0B56BC.6080601@yandex.ru> In-Reply-To: <4F0B56BC.6080601@yandex.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: archivers/zip in 9.x: X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 21:11:34 -0000 Ruslan Mahmatkhanov wrote on 10.01.2012 01:06: > Michael Scheidell wrote on 10.01.2012 00:30: >> I think I saw something in the list that FreeBSD 9.x has zip already >> built in? so, ports that need 'zip' won't need zip? >> >> for maintainers, they should use something like: >> >> USE_ZIP= yes >> >> to: >> >> if ${OSVERSION} <= 900000 >> USE_ZIP= yes >> .endif >> >> and/or BUILD_DEPENDS+= zip:${PORTSDIR}/archivers/zip >> >> (at what OSVERSION was zip included in the base?) >> >> > > unzip, not zip. I believe it should be handled in bsd.port.mk like it > done for USE_XZ. Something like: > > .if defined(USE_ZIP) && ${OSVERSION} < 900000 > EXTRACT_DEPENDS+= ${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip > .endif > > Correct OSVERSION should be used instead of 900000. There is also should > be some logic for UNZIP_CMD. > .if exists(/usr/bin/unzip) UNZIP_CMD?= /usr/bin/unzip .else UNZIP_CMD?= ${LOCALBASE}/bin/unzip .endif in bsd.commands.mk -- Regards, Ruslan Tinderboxing kills... the drives.