From owner-freebsd-net@FreeBSD.ORG Wed Mar 17 05:32:22 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3F5F16A4CF for ; Wed, 17 Mar 2004 05:32:22 -0800 (PST) Received: from proton.hexanet.fr (proton.hexanet.fr [81.23.32.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id E8B7F43D2F for ; Wed, 17 Mar 2004 05:32:21 -0800 (PST) (envelope-from c.prevotaux@hexanet.fr) Received: from hexanet.fr (localhost [127.0.0.1]) by proton.hexanet.fr (Postfix) with SMTP id 7F7B44C963; Wed, 17 Mar 2004 14:32:20 +0100 (CET) Date: Wed, 17 Mar 2004 14:32:20 +0100 From: Christophe Prevotaux To: David Malone Message-Id: <20040317143220.6cd28174.c.prevotaux@hexanet.fr> In-Reply-To: <200403171152.aa43952@salmon.maths.tcd.ie> References: <200403171152.aa43952@salmon.maths.tcd.ie> Organization: HEXANET Sarl X-Mailer: Sylpheed version 0.9.6 (GTK+ 1.2.10; i386-portbld-freebsd4.9) X-NCC-RegID: fr.hexanet Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable cc: freebsd-net@freebsd.org Subject: Re: PPPoE buglet... X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2004 13:32:22 -0000 Yes please fix it.=20 On Wed, 17 Mar 2004 11:52:53 +0000 David Malone wrote: > I spent a while trying to get PPPoE going through a Netopia smart > modem last night. To cut a long story short, the values for > PTT_RELAY_SID in src/sys/netgraph/ng_pppoe.h are wrong (at least > when compared with tcpdump, linux and the RFC). We have: >=20 > #if BYTE_ORDER =3D=3D BIG_ENDIAN > #define PTT_RELAY_SID (0x0106) > #else > #define PTT_RELAY_SID (0x0601) > #endif >=20 > but we should have: >=20 > #if BYTE_ORDER =3D=3D BIG_ENDIAN > #define PTT_RELAY_SID (0x0110) > #else > #define PTT_RELAY_SID (0x1001) > #endif >=20 > Anyone object to my fixing it? The only thing I can think of that > it might break would be people using ng_pppoe as a PPPoE relay with > only ng_pppoe PPPoE clients. >=20 -- =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Christophe Prevotaux Email: c.prevotaux@hexanet.fr HEXANET SARL URL: http://www.hexanet.fr/ Z.A.C Les Charmilles Tel: +33 (0)3 26 79 30 05=20 3 All=E9e Thierry Sabine Direct: +33 (0)3 26 61 77 72=20 BP202 Fax: +33 (0)3 26 79 30 06 51686 Reims Cedex 2 =20 FRANCE HEXANET Network Operation Center =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D