Date: Mon, 16 May 2005 18:47:46 +0300 From: Giorgos Keramidas <keramida@freebsd.org> To: "David O'Brien" <obrien@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/top machine.c Message-ID: <20050516154746.GA31676@orion.daedalusnetworks.priv> In-Reply-To: <20050516101515.GA676@orion.daedalusnetworks.priv> References: <200504161543.j3GFhclO075103@repoman.freebsd.org> <20050516001837.GA65506@dragon.NUXI.org> <20050516004059.GA15002@gothmog.gr> <20050516032743.GA89903@dragon.NUXI.org> <20050516101515.GA676@orion.daedalusnetworks.priv>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2005-05-16 13:15, Giorgos Keramidas <keramida@freebsd.org> wrote: > If you think that hard-limiting USERNAME to 8 columns is fine, then I'm > all for it, please commit :-) Ok, I've tested the same change here too. It seems to work fine (except for the minor nit of using a statically initialized variable for something that can be a constant, but top has so many ``buglets'' already that this is not too important). The version of top that I used on my workstation at work today includes the following changes: - Proper trimming of the header to avoid the nasty wraparound of the header that BDE mentioned. - Hard-limiting of USERNAME to 8 columns. - Merged CPU/WCPU columns that can be toggled with 'C'. The sources for this are available at: http://people.freebsd.org/~keramida/top-keramida.tgz The CVS tree where I worked on these changes is available online too, at: http://serverhive.com/cgi-bin/cvsweb.cgi/freebsd/top/?cvsroot=pcvs David, do you think you could review and/or commit some of the changes if I posted the diffs to you? - Giorgos
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050516154746.GA31676>