Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Apr 2005 11:02:06 +0200
From:      Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
To:        Sam Lawrance <lawrance@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/math/vtk-java Makefile
Message-ID:  <20050425090206.GA82306@arabica.esil.univ-mrs.fr>
In-Reply-To: <200504250347.j3P3lopR048231@repoman.freebsd.org>
References:  <200504250347.j3P3lopR048231@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 25, 2005 at 03:47:50AM +0000, Sam Lawrance wrote:
> lawrance    2005-04-25 03:47:50 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     math/vtk-java        Makefile 
>   Log:
>   Fix plist error - only create example directories when WITH_TESTING is set.
>   
>   Reported by:    pointykris
>   Approved by:    clement (mentor, implicit)
>   
>   Revision  Changes    Path
>   1.6       +1 -1      ports/math/vtk-java/Makefile

I missed the previous commit in which you updated the port to
bsd.java.mk 2.0. There is a small issue with the update:

  JAVA_BUILD=	jdk

This statement is useless, as the default behaviour, when nothing is
specified (neither JAVA_BUILD, JAVA_RUN, nor JAVA_EXTRACT) is the
following:

  JAVA_BUILD=	jdk
  JAVA_RUN=	jre

Moreover, if you do specify JAVA_BUILD but not JAVA_RUN, the port will
not register any run dependency on the selected JDK:

$ cd /usr/ports/math/vtk-java
$ make run-depends-list
/usr/ports/graphics/jpeg
/usr/ports/graphics/png
/usr/ports/graphics/tiff
/usr/ports/math/vtk
/usr/ports/textproc/expat2
/usr/ports/x11/xorg-libraries

--> no JDK

I would have fixed it myself, but I took the opportunity to inform
commiters on the topic. Plus, you probably want to discuss this with the
maintainer, in case a JDK is actually not required to run the port
(which I doubt anyway).

Herve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050425090206.GA82306>