From owner-freebsd-doc@FreeBSD.ORG Thu Jan 18 19:52:57 2007 Return-Path: X-Original-To: freebsd-doc@freebsd.org Delivered-To: freebsd-doc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1508C16A407; Thu, 18 Jan 2007 19:52:57 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 9E65713C43E; Thu, 18 Jan 2007 19:52:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l0IJRh52065070; Thu, 18 Jan 2007 14:27:43 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-doc@freebsd.org Date: Thu, 18 Jan 2007 14:27:51 -0500 User-Agent: KMail/1.9.1 References: <200701171832.28368.dienst@marcrenearns.de> <20070118095724.GS5594@elvandar.org> <474078f80701180950s5e307d27lf91d2d2f2322737b@mail.gmail.com> In-Reply-To: <474078f80701180950s5e307d27lf91d2d2f2322737b@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701181427.52998.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 18 Jan 2007 14:27:43 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2462/Thu Jan 18 05:07:46 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: re@freebsd.org, Murray Stokely , ru@freebsd.org, doc@freebsd.org, Marc Ren? Arns Subject: Re: make buildkernel fails without complete source tree X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2007 19:52:57 -0000 On Thursday 18 January 2007 12:50, Murray Stokely wrote: > On 1/18/07, Remko Lodder wrote: > > This is not true. I downloaded the packages which are being used by sysinstall > > and extracted them. I found the Makefile, it was properly filled with instructions. > > It looks to me like src/release/makefile builds the tar file ssys.tar > by just tarring /usr/src/sys and therefore would in fact be missing > /usr/src/Makefile and /usr/src/Makefile.inc1 necessary for "make > buildkernel". > > Taking a look at the tar file: > > cat ssys.a?? > ssys.tar && tar tvf ssys.tar > > I see that only files in /usr/src/sys are included. > > We could add a tar -r -f .. /usr/src/Makefile /usr/src/Makefile.inc1 > to release.7 in /usr/src/release/Makefile to automatically add these > two files as a special case to the ssys distribution. CCing re@ for > any comments on that proposal. Those are already in sbase. I think the menu options that say "just install kernel sources" should enable sbase as well as ssys, and if someone then goes and turns it off they get what they asked for. And in fact, sysinstall already does this: int distSetKernDeveloper(dialogMenuItem *self) { int i; distReset(NULL); Dists = _DIST_DEVELOPER; SrcDists = DIST_SRC_SYS | DIST_SRC_BASE; KernelDists = selectKernel(); i = distMaybeSetPorts(self); distVerifyFlags(); return i; } So in this case you are dealing with someone who explicitly only asked for 'ssys'. I think we delivered the foot to the bullet quite well. :) Maybe add a comment though to the menu like: Index: menus.c =================================================================== RCS file: /usr/cvs/src/usr.sbin/sysinstall/menus.c,v retrieving revision 1.421 diff -u -r1.421 menus.c --- menus.c 10 Dec 2006 16:33:38 -0000 1.421 +++ menus.c 18 Jan 2007 19:25:46 -0000 @@ -1096,7 +1096,7 @@ dmenuFlagCheck, dmenuSetFlag, NULL, &SrcDists, '[', 'X', ']', DIST_SRC_SSECURE }, { " share", "/usr/src/share (documents and shared files)", dmenuFlagCheck, dmenuSetFlag, NULL, &SrcDists, '[', 'X', ']', DIST_SRC_SHARE }, - { " sys", "/usr/src/sys (FreeBSD kernel)", + { " sys", "/usr/src/sys (FreeBSD kernel; requires 'base' to build)", dmenuFlagCheck, dmenuSetFlag, NULL, &SrcDists, '[', 'X', ']', DIST_SRC_SYS }, { " tools", "/usr/src/tools (miscellaneous tools)", dmenuFlagCheck, dmenuSetFlag, NULL, &SrcDists, '[', 'X', ']', DIST_SRC_TOOLS }, I've tested it and the menu still fits in 80x25 with this. I wouldn't do anything more than this though. -- John Baldwin