From owner-cvs-src@FreeBSD.ORG Mon Jan 23 19:58:26 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 422B916A41F; Mon, 23 Jan 2006 19:58:26 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A71644261; Mon, 23 Jan 2006 19:58:24 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 6784141 for multiple; Mon, 23 Jan 2006 14:59:33 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k0NJwLGY002949; Mon, 23 Jan 2006 14:58:22 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Tom Rhodes Date: Mon, 23 Jan 2006 14:59:22 -0500 User-Agent: KMail/1.9.1 References: <200601211210.k0LCAXYl069896@repoman.freebsd.org> <200601231356.18292.jhb@freebsd.org> <20060123142822.1be78fcb.trhodes@FreeBSD.org> In-Reply-To: <20060123142822.1be78fcb.trhodes@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200601231459.25281.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1247/Sat Jan 21 05:24:51 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/nfsserver nfs_serv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2006 19:58:26 -0000 On Monday 23 January 2006 14:28, Tom Rhodes wrote: > On Mon, 23 Jan 2006 13:56:16 -0500 > > John Baldwin wrote: > > On Saturday 21 January 2006 07:10, Tom Rhodes wrote: > > > trhodes 2006-01-21 12:10:33 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/nfsserver nfs_serv.c > > > Log: > > > Remove some dead code. > > > > > > Found with: Coverity Prevent(tm) > > > > Are you going to revert this change given the replies? > > Oh, I didn't interpret the comments as "this is wrong please > back it out." I just seen replies, both public and private, > complaining about the indentation. They went like: > > stefanf: "Are you sure this is correct?" When someone says this, you generally should be able to reply with either "Yes, because of X, Y, and Z", or "oops, I guess not, I'll back it out" > rwatson: "code is a mess in NFS" > > ru: quoting the code "bad indentation" > njl quoting the code "bad indentation" > > rees (NFSv4 guy): "looks fine to me" > > If you, or anyone else for that matter actually wants it > reverted, I'll do that. I'm not in the mood to argue > with people today, or ever. :) Hm, are you sure this change is correct? Apparently Coverity thinks that dirp is always 0 at this point, yes? Looking at nfs_namei() I don't believe that. Note the "I don't believe that" part. I'll put my $0.02 in and agree with Stefan Farfeleder. (Luckily, in this case, the notorious NFS macros are not involved). The comments on nfs_namei() state that dirp can be returned not-NULL even if an error occurs and a check of the code paths in nfs_namei() indicates that this is correct. Can you please re-evaluate your change. If (as I suspect), this is actually an incorrect report from Coverity, we should probably report it back to them to investigate. Please either offer explanations to address the concerns raised or back it out. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org