From owner-freebsd-arch@FreeBSD.ORG  Fri Dec  3 20:50:47 2004
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CCEDE16A4CE
	for <arch@freebsd.org>; Fri,  3 Dec 2004 20:50:47 +0000 (GMT)
Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 604C943D2D
	for <arch@freebsd.org>; Fri,  3 Dec 2004 20:50:47 +0000 (GMT)
	(envelope-from marcel@xcllnt.net)
Received: from ns1.xcllnt.net (localhost [127.0.0.1])
	by ns1.xcllnt.net (8.13.1/8.13.1) with ESMTP id iB3KoexI016681;
	Fri, 3 Dec 2004 12:50:41 -0800 (PST)
	(envelope-from marcel@ns1.xcllnt.net)
Received: (from marcel@localhost)
	by ns1.xcllnt.net (8.13.1/8.13.1/Submit) id iB3KoelO016680;
	Fri, 3 Dec 2004 12:50:40 -0800 (PST)
	(envelope-from marcel)
Date: Fri, 3 Dec 2004 12:50:40 -0800
From: Marcel Moolenaar <marcel@xcllnt.net>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-ID: <20041203205040.GA16617@ns1.xcllnt.net>
References: <200412030813.iB38DA12044595@repoman.freebsd.org>
	<20041203.110520.54185564.imp@bsdimp.com>
	<20041203194201.GB16093@ns1.xcllnt.net>
	<20041203.132650.04772724.imp@bsdimp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041203.132650.04772724.imp@bsdimp.com>
User-Agent: Mutt/1.4.2.1i
cc: arch@freebsd.org
Subject: Re: cvs commit: src/sys/dev/pci pci.c
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Dec 2004 20:50:48 -0000

On Fri, Dec 03, 2004 at 01:26:50PM -0700, M. Warner Losh wrote:
> : > We likely should have a sys/$MACHINE_ARCH/include/_config.h that has a
> : > bunch of #defines that we can test instead of specific architecture
> : > lists, don't you think?
> : 
> : A <machine/_config.h> doesn't give me warm fuzzies. Maybe we can
> : rename <machine/pci_cfgreg.h> to <machine/pci.h> and give it some
> : additional use (for this particular case of course).
> 
> There's a growing number of these sorts of things.  NetBSD has this
> information in machine/types.h.  For example:
> 
> #include <mips/types.h>
> 
> #define __HAVE_GENERIC_SOFT_INTERRUPTS
> #define __HAVE_DEVICE_REGISTER
> #define __HAVE_NWSCONS
> 
> #define __HAVE_MIPS_MACHDEP_CACHE_CONFIG
> 
> I was thinking that we should start doing something similar...

For some reason I have a bad feeling about this. It's soooo easily
misused. For one, it's a good way to cover up a bad design or an
incomplete implementation. It goes no further than a feeling though.
There's nothing wrong with it in principle, because differences do
exist.

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel@xcllnt.net