From owner-cvs-all Sun Jun 4 19:39: 2 2000 Delivered-To: cvs-all@freebsd.org Received: from florence.pavilion.net (florence.pavilion.net [212.74.0.25]) by hub.freebsd.org (Postfix) with ESMTP id C36A637B6D7; Sun, 4 Jun 2000 19:38:54 -0700 (PDT) (envelope-from joe@pavilion.net) Received: from genius.systems.pavilion.net (genesis.tao.org.uk [194.242.131.254]) by florence.pavilion.net (8.9.3/8.8.8) with ESMTP id DAA33722; Mon, 5 Jun 2000 03:38:53 +0100 (BST) (envelope-from joe@pavilion.net) Received: by genius.systems.pavilion.net (Postfix, from userid 100) id 2CC4B82; Mon, 5 Jun 2000 03:39:10 +0100 (BST) Date: Mon, 5 Jun 2000 03:39:10 +0100 From: Josef Karthauser To: "Andrey A. Chernov" Cc: Josef Karthauser , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/ls Makefile extern.h ls.c ls.h print.c Message-ID: <20000605033910.S620@pavilion.net> References: <200006050214.TAA18352@freefall.freebsd.org> <20000604192104.A99868@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20000604192104.A99868@freebsd.org>; from ache@FreeBSD.ORG on Sun, Jun 04, 2000 at 07:21:05PM -0700 X-NCC-RegID: uk.pavilion Organisation: Pavilion Internet plc, Lees House, 21-23 Dyke Road, Brighton, England Phone: +44-845-333-5000 Fax: +44-845-333-5001 Mobile: +44-403-596893 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, Jun 04, 2000 at 07:21:05PM -0700, Andrey A. Chernov wrote: > On Sun, Jun 04, 2000 at 07:14:01PM -0700, Josef Karthauser wrote: > > joe 2000/06/04 19:14:01 PDT > > > > Modified files: > > bin/ls Makefile extern.h ls.c ls.h print.c > > Log: > > * Re-implement colour support using termcap's AF and AB capabilities > > to manage the ANSI colour sequences. Colour support is disabled > > unless the TERM environment variable references a valid termcap. > > if (tgetent(NULL, getenv("TERM")) == 1) > > this is illegal termlib call, you must specify at least 1024 bytes buffer as > first argument. Can do, but when I went looking through the man page for the correct sizing all I could find was: The tgetent routine loads the entry for name. It returns 1 on success, 0 if there is no such entry, and -1 if the terminfo database could not be found. The emulation ignores the buffer pointer bp. In the name of compatibility with other implementations I'll fix it for a 1024 byte buffer. Joe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message