From owner-freebsd-stable@FreeBSD.ORG Wed Oct 19 23:45:18 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B5E31106566B; Wed, 19 Oct 2011 23:45:18 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate.funkthat.com [70.36.235.232]) by mx1.freebsd.org (Postfix) with ESMTP id 5E0958FC08; Wed, 19 Oct 2011 23:45:18 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id p9JN6i3o008800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Oct 2011 16:06:44 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id p9JN6gZ7008798; Wed, 19 Oct 2011 16:06:42 -0700 (PDT) (envelope-from jmg) Date: Wed, 19 Oct 2011 16:06:42 -0700 From: John-Mark Gurney To: Alberto Villa Message-ID: <20111019230642.GV14645@funkthat.com> Mail-Followup-To: Alberto Villa , "Wojciech A. Koszek" , marius@freebsd.org, "marcel@freebsd.org" , freebsd-stable@freebsd.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Wed, 19 Oct 2011 16:06:44 -0700 (PDT) Cc: marius@freebsd.org, "marcel@freebsd.org" , freebsd-stable@freebsd.org, "Wojciech A. Koszek" Subject: Re: (Possible fix for sbp(4)) Re: Comment out sbp driver from GENERIC X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2011 23:45:18 -0000 Alberto Villa wrote this message on Tue, Oct 18, 2011 at 14:12 +0200: > On Tue, Oct 18, 2011 at 1:48 PM, Wojciech A. Koszek > wrote: > > Commenting a driver out is almost always a bad idea and should > > be done as a last step. > > Well, few weeks prior to -RELEASE can be considered a last step. :) Considering that no discussion has happened on the -firewire list, nor does there appear to be any active PRs tracking this, I think it's a bad idea to remove the sbp. If someone spends the time to properly file a bug report, then we can tie the reinclusion of sbp to fixing the PR. If we disabled everything that hangs on one or two systems, we wouldn't have many devices in the kernel. The closest bug I could find that relate to this issue is kern/97208. The last activity on this bug was over two years ago, so clearly not many people are reporting the issue to the propler places (-firewire or PR database). -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."