From owner-cvs-all Fri Jan 31 13: 3:47 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3420737B401; Fri, 31 Jan 2003 13:03:46 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF1CC43F93; Fri, 31 Jan 2003 13:03:44 -0800 (PST) (envelope-from phk@freebsd.org) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h0VL3e4W043528; Fri, 31 Jan 2003 22:03:40 +0100 (CET) (envelope-from phk@freebsd.org) To: Julian Elischer Cc: John Baldwin , "Tim J. Robbins" , cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_trap.c From: phk@freebsd.org In-Reply-To: Your message of "Fri, 31 Jan 2003 12:57:21 PST." Date: Fri, 31 Jan 2003 22:03:40 +0100 Message-ID: <43527.1044047020@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , Ju lian Elischer writes: >On Fri, 31 Jan 2003, John Baldwin wrote: >> Reviewed by: julian >> ----- >> >> [...] Either way, I want this commit backed out >> until such time as it has a 'Reviewed by' line that means something. > >John I'm not saying that the patch shouldn't have been tested more, [...] Add my vote to the "backout" request. Julian: You are Davids mentor, the way you try to excuse your lack of review by largely blaming David is disgraceful. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message