From owner-svn-ports-head@freebsd.org Wed Jul 1 15:28:19 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C394A354EED; Wed, 1 Jul 2020 15:28:19 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49xlVW0kSDz4dgL; Wed, 1 Jul 2020 15:28:18 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: by mail-il1-x141.google.com with SMTP id t18so1464509ilh.2; Wed, 01 Jul 2020 08:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=4XpUWf1QYXfs7GJ3i5Iio6piVvTo3OOVS3HRlNCN4d0=; b=s+QqUGCCu8YH6AjZN4UflMNotI+R/8ybmrwRry4xNrzKQBypWhDV06u0o7sIhMt1Oj X4QLgfxWUHiMYIE8IYRNilTOSIa5vrszXEgFB287ZOL+pQtqgx/SBEW1TzFszilfkjQl ztaFZGUmw167Zm6ZbFW8ngYkbCcddIMb/R6rsJGffgMf11xedNto+39FT1YlZWk8kmIR 7CHmM5D6VSUSJNPpDsQXr+WXtrP0N7t5NtUoy47zE3GUdtQysJ0iR+XbKQ3IWjPqp0eM qFsCHorKBSJnpNHvFRLSAPkOuqoUQZJt75r6OOuQniqiJtmbGFlJxVJbp9vKkncL/a2l Zcjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=4XpUWf1QYXfs7GJ3i5Iio6piVvTo3OOVS3HRlNCN4d0=; b=k3OZALExtTdWdmxv1sovpIDhKBd858Hwc86mx/P904zwOMqOLDIiGJBa2vDXRueQ10 VrBAaiskFqszD1jnXJw7R1f5YdIOFOHmPDhOH+oLHTLm15fhLsXFYf9e0hbxqHrM4Oby Zp9VAKn7w2TfmWCP+5wmQ8iQkhAzNFlMCo3kh/+HqhcHG4MTvDU8ROZJzyDRuHZ7VAZ4 ErdlXT++2bLHqti36h8IsWU5tAk9TMQ9hyegkWp9EMjI3ni8ZvqDulKwmqLOMXv9MSFr j8g8LT0IQsIcydGChVYMJVpQcWYB+EUzB5a1ErTBxKtagIa3AsUWyh26n18o2qJUz0+R FhVg== X-Gm-Message-State: AOAM530EOJhagPrryPaPnZO+80AmjWAlN8N2D4eqtqznYnoG8fcSa5b0 ZolslGLK6XqnhECEqY5AOGL9AYeTPRo= X-Google-Smtp-Source: ABdhPJy0VcG81m7vSJ9re37vY25NsBR6lprALnkAz/+JQWyhJ4xCwRe/j5lwdJs7OdflUa9eCX3Vog== X-Received: by 2002:a92:bb55:: with SMTP id w82mr8497165ili.146.1593617297066; Wed, 01 Jul 2020 08:28:17 -0700 (PDT) Received: from coral.acadix.biz (2603-6000-a40b-4f00-0223-24ff-fe37-c4d7.res6.spectrum.com. [2603:6000:a40b:4f00:223:24ff:fe37:c4d7]) by smtp.gmail.com with ESMTPSA id v16sm3313043iow.19.2020.07.01.08.28.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2020 08:28:16 -0700 (PDT) Subject: Re: svn commit: r540967 - in head/net/lualdap: . files To: Alexey Dokuchaev , Li-Wen Hsu Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202007011406.061E6Cxt041119@repo.freebsd.org> <20200701151607.GA6554@FreeBSD.org> From: Jason Bacon Message-ID: Date: Wed, 1 Jul 2020 10:28:15 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200701151607.GA6554@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspamd-Queue-Id: 49xlVW0kSDz4dgL X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=s+QqUGCC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of bacon4000@gmail.com designates 2607:f8b0:4864:20::141 as permitted sender) smtp.mailfrom=bacon4000@gmail.com X-Spamd-Result: default: False [-2.90 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.98)[-0.975]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-0.996]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(0.07)[0.069]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::141:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2020 15:28:19 -0000 On 2020-07-01 10:16, Alexey Dokuchaev wrote: > On Wed, Jul 01, 2020 at 02:06:12PM +0000, Li-Wen Hsu wrote: >> New Revision: 540967 >> URL: https://svnweb.freebsd.org/changeset/ports/540967 >> >> Log: >> Update to 1.2.5 >> =20 >> ... >> -MAKE_ARGS+=3D LUA_LIBDIR=3D"${LUA_LIBDIR}" \ >> - LUA_INC=3D"${LUA_INCDIR}" \ >> - OPENLDAP_LIB=3D"-L${LOCALBASE}/lib -lldap" \ >> - LUA_VERSION_NUM=3D"${LUA_VER_STR}0" \ >> - CC=3D"${CC}" >> +MAKE_ARGS+=3D CPPFLAGS=3D"-I${LOCALBASE}/include -I${LUA_INCDIR}" \ >> + LDFLAGS=3D"-L${LOCALBASE}/lib" \ >> + CC=3D${CC} > Dropping quotes around ${CC} can potentially break things and also > had contributed some unnecessary repo churn. :( > > ./danfe I would have thought ${CC} is always just the compiler name sans=20 flags/whitespace, but danfe is correct.=C2=A0 There's one case in Mk that= =20 would call for quotes: FreeBSD coral.acadix=C2=A0 bacon ~ 1004: grep -r=C2=A0 ^CC=3D=C2=A0 /usr/= ports/Mk/ [snip] /usr/ports/Mk/bsd.port.mk:CC=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 ${XCC} --sysroot=3D${CROSS_SYSROOT} --=20 Earth is a beta site.